Library[1,4,5,6]NegativeTest is overly restrictive #354
Comments
|
This comment was originally written by jimhug@google.com Test TypeVariableBoundsTest/05 appears to share roughly the same issue - where it is expecting a compile-time error from a member that is never invoked. |
|
This comment was originally written by jimhug@google.com And two more tests that appear to be the same issue: Field3NegativeTest FieldOverrideTest has the slightly more complicated version where the types are instantiated, but the invalid field (named 'field') is not ever referenced which I believe should also be within the legal bounds of a compile without --compile_all. |
|
This comment was originally written by drfibonacci@google.com |
|
This comment was originally written by jimhug@google.com I'm going to close this as resolved. The issue was a test issue and has been resolved as the tests are correct. The frog issue is captured clearly enough by language.status. Removed Priority-High, Area-Frog labels. |
DartBot
added
Type-Defect
area-test
strong mode inference. This CL adds instance fields to the set of variables for which dependencies are computed, and re-resolves each instance field initializer using type information inferred for the static variables upon which it depends. This CL also stops static variables with existing type information from having their types overwritten. This CL ports over a number of the DDC inference tests, more remain to be ported. There is still at least one outstanding issue with instance variable inference, see #354 (and the two tests marked fail added in this CL). BUG= R=brianwilkerson@google.com Review URL: https://codereview.chromium.org//1370793002 .
This issue was originally filed by jimhug@google.com
These 4 tests check for conflicting names - but never actually reference those names. These tests should be allowed to pass unless the --compile_all flag is used to force full compilation and checking. These tests can all be trivially fixed by adding a reference in code (reachable from main) to the offending names.
This issue is equivalent to the one addressed in this commit (with accompanying code review discussion):
http://code.google.com/p/dart/source/detail?spec=svn1233&r=1055
The text was updated successfully, but these errors were encountered: