-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make it easier to go to an imported library #3571
Comments
You don't have to select the whole string. It works if the cursor is anywhere within the string. Since directives are line-oriented it would be good to change the hyperlinking/F3 behavior to work on the entire line. Good input, thanks. Added this to the Later milestone. |
Added NotPlanned label. |
How does this have a milestone of M5 but a status of NotPlanned? |
Bump pub to 6fdcdd4357645817e7d7027ee2157ed68ef69c53 Changes: ``` > git log --format="%C(auto) %h %s" 6ac42d7..6fdcdd4 https://dart.googlesource.com/pub.git/+/6fdcdd43 Support `--native-assets` in kernel compilation commands (#3667) https://dart.googlesource.com/pub.git/+/7202dd5e Fix error message for missing transitive dependency (#3196) https://dart.googlesource.com/pub.git/+/ab3304e1 Ignore analysis_options.yaml everywhere (#3666) https://dart.googlesource.com/pub.git/+/54e0b1eb Only check for sdk updates during resolveExecutable (#3665) https://dart.googlesource.com/pub.git/+/327d9ee8 Fix global activate --git-ref (#3656) https://dart.googlesource.com/pub.git/+/1485d60c Add env var flag to override stdout.hasTerminal for output animations (#3658) https://dart.googlesource.com/pub.git/+/13ca9de1 Fix escapeShellArgument (#3663) https://dart.googlesource.com/pub.git/+/75c671c7 Allow adding from multiple sources (#3571) https://dart.googlesource.com/pub.git/+/1acfd4f7 dart pub get --enforce-lockfile (#3637) https://dart.googlesource.com/pub.git/+/9810fc6f Suggest using 2.12 as lower-bound SDK constraint (#3660) https://dart.googlesource.com/pub.git/+/f481f27a Add a README.md to the pub cache after command ends (#3650) https://dart.googlesource.com/pub.git/+/d54d52d3 Have executableForCommand rerun pub get if sdk changed minor version (#3652) https://dart.googlesource.com/pub.git/+/ea986525 Delete move.yml (#3648) ``` Diff: https://dart.googlesource.com/pub.git/+/6ac42d7644dedfcc500147ab47886eecab4b1b38~..6fdcdd4357645817e7d7027ee2157ed68ef69c53/ Bump webdev to 637b406f325669507b5c1048c19a7c0083c1bd6e Changes: ``` > git log --format="%C(auto) %h %s" 3ec168f..637b406 https://dart.googlesource.com/webdev.git/+/637b406 Support `--native-assets` in `FrontendServerClient` (#1797) https://dart.googlesource.com/webdev.git/+/a19d563 Save debug information in `chrome.storage` after a Dart app loads (#1791) https://dart.googlesource.com/webdev.git/+/9cc10d4 Connect to a `chrome.runtime` port to keep the service worker alive (#1789) ``` Diff: https://dart.googlesource.com/webdev.git/+/3ec168f6815af9d5f11278111d147bc82c0755c3~..637b406f325669507b5c1048c19a7c0083c1bd6e/ Update CHANGELOG Bump pub to 6fdcdd4357645817e7d7027ee2157ed68ef69c53 Changes: ``` > git log --format="%C(auto) %h %s" 6ac42d7..6fdcdd4 https://dart.googlesource.com/pub.git/+/6fdcdd43 Support `--native-assets` in kernel compilation commands (#3667) https://dart.googlesource.com/pub.git/+/7202dd5e Fix error message for missing transitive dependency (#3196) https://dart.googlesource.com/pub.git/+/ab3304e1 Ignore analysis_options.yaml everywhere (#3666) https://dart.googlesource.com/pub.git/+/54e0b1eb Only check for sdk updates during resolveExecutable (#3665) https://dart.googlesource.com/pub.git/+/327d9ee8 Fix global activate --git-ref (#3656) https://dart.googlesource.com/pub.git/+/1485d60c Add env var flag to override stdout.hasTerminal for output animations (#3658) https://dart.googlesource.com/pub.git/+/13ca9de1 Fix escapeShellArgument (#3663) https://dart.googlesource.com/pub.git/+/75c671c7 Allow adding from multiple sources (#3571) https://dart.googlesource.com/pub.git/+/1acfd4f7 dart pub get --enforce-lockfile (#3637) https://dart.googlesource.com/pub.git/+/9810fc6f Suggest using 2.12 as lower-bound SDK constraint (#3660) https://dart.googlesource.com/pub.git/+/f481f27a Add a README.md to the pub cache after command ends (#3650) https://dart.googlesource.com/pub.git/+/d54d52d3 Have executableForCommand rerun pub get if sdk changed minor version (#3652) https://dart.googlesource.com/pub.git/+/ea986525 Delete move.yml (#3648) ``` Diff: https://dart.googlesource.com/pub.git/+/6ac42d7644dedfcc500147ab47886eecab4b1b38~..6fdcdd4357645817e7d7027ee2157ed68ef69c53/ Change-Id: I65b928479b44f08305853078b0f34a6b66602709 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/271709 Auto-Submit: Sigurd Meldgaard <sigurdm@google.com> Reviewed-by: Jonas Jensen <jonasfj@google.com> Commit-Queue: Jonas Jensen <jonasfj@google.com>
When there's an import statement, say, of the form
import('../../../lib/unittest/unittest.dart');
and I'd like to see what's available in unittest it's non-obvious how to do that. I can ctrl-hover over the string portion, but didn't know about that. I assume it's an Eclipsism, but if people aren't Eclipse users they might not figure it out. Also, hovering-based things are potentially an issue for people not using mice, which affects both accessibility and people using touchscreens. You can also select inside the string and use F3 to go to it, but it's inconvenient to select the string. It would be nice if you could just select the line and F3 was clever about import statements and similar. Or even just have F3 parse the whole line the cursor is on if there's no selection. And probably nicer in terms of making it obvious if the F3 menu item changed its name to reflect what it was going to open.
The text was updated successfully, but these errors were encountered: