-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement toStringAsFixed, toStringAsExponential, toStringAsPrecision for integers #460
Comments
Added Accepted label. |
FYI, I hit this in the Dromaeo benchmark. I can work around by converting to double first. |
I have a fix ready shortly (although it may not make sense to call toStringAsFixed on integers, since there is no fraction). |
toStringAsExponential and toStringAsPrecision are not implemented in C++ yet, assigning to floitsch. Set owner to @floitschG. |
Fixed in r4681. Added Fixed label. |
Reopening and unassigning me. Removed the owner. |
Set owner to @sgmitrovic. |
The integers methods have been already implemented as x.toDouble().toStringAsFixed(). Added Fixed label. |
R=jmesserly@google.com Review URL: https://codereview.chromium.org/1718353002 .
LibTest/core/int/toStringAsExponential/int/toStringAsExponential/A01/t01: Fail
LibTest/core/int/toStringAsFixed/int/toStringAsFixed/A01/t01: Fail
LibTest/core/int/toStringAsPrecision/int/toStringAsPrecision/A01/t01: Fail
The text was updated successfully, but these errors were encountered: