Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider allocating more aggressively during different phases of the VM #47574

Open
dnfield opened this issue Oct 29, 2021 · 5 comments
Open

Consider allocating more aggressively during different phases of the VM #47574

dnfield opened this issue Oct 29, 2021 · 5 comments
Assignees
@rmacnak-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-flutter P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team

Comments

@dnfield
Copy link
Contributor

dnfield commented Oct 29, 2021

For example, during startup, allocate more aggressively until some point where the program "settles", e.g. in a Flutter application has started drawing frames.

@rmacnak-google @a-siva
@a-siva
Copy link
Contributor

a-siva commented Oct 30, 2021

For this I believe we could consider the RAIL ( Response, Animation, Idle, Loading) model that v8 GC adopts.
The Engine would have to provide notification on the different phases (like it currently does for I (idle)) and the VM could adapt some of the GC heuristics accordingly.

@devoncarew devoncarew added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-flutter labels Nov 1, 2021
@iskakaushik
Copy link

cc: @iskakaushik

@a-siva a-siva added the P2 A bug or feature request we're likely to work on label Jul 25, 2022
@a-siva a-siva mentioned this issue Jul 25, 2022
Closed
@fzyzcjy
Copy link
Contributor

fzyzcjy commented Jul 25, 2022

👀 Is there any updates

copybara-service bot pushed a commit that referenced this issue Jul 27, 2022
@rmacnak-google
[vm, gc] Very basic RAIL.
c6a1eb1 
Related to #47574

TEST=ci
Change-Id: I2f07be6150b025a301e6e4d10935b606087cdf00
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/252462
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
@a-siva a-siva mentioned this issue Sep 19, 2022
Closed
@a-siva
Copy link
Contributor

a-siva commented Oct 28, 2022

@dnfield @iskakaushik Is there any more work to be done on this ?

@dnfield
Copy link
Contributor Author

dnfield commented Oct 28, 2022

What's the status of it for startup? I'm only up to date on the work that was done for throughput during animation.

@a-siva a-siva added triaged Issue has been triaged by sub team and removed vm-triaged labels Dec 20, 2022
@a-siva a-siva mentioned this issue Jul 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. customer-flutter P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@iskakaushik @devoncarew @fzyzcjy @rmacnak-google @dnfield @a-siva