Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WeakReference, Finalizer and NativeFinalizer to core libraries #47773

Closed
Tracked by #47772
mraleph opened this issue Nov 25, 2021 · 1 comment
Closed
Tracked by #47772

Add WeakReference, Finalizer and NativeFinalizer to core libraries #47773

mraleph opened this issue Nov 25, 2021 · 1 comment
Assignees
@lrhn
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-core library-ffi type-task A well-defined stand-alone task

Comments

@mraleph
Copy link
Member

mraleph commented Nov 25, 2021

No description provided.

@mraleph mraleph mentioned this issue Nov 25, 2021
Closed
6 tasks
@mraleph mraleph added area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. and removed area-test Cross-cutting test issues (use area- labels for specific failures; not used for package:test). labels Nov 25, 2021
@lrhn lrhn added type-task A well-defined stand-alone task library-core library-ffi labels Nov 29, 2021
@lrhn lrhn self-assigned this Nov 29, 2021
copybara-service bot pushed a commit that referenced this issue Jan 7, 2022
@lrhn
Add WeakReference and Finalizer to dart:core.
d095700 
This adds the abstract classes with external factory constructors,
and adds throwing constructors to all backed patch files.

Further implementation can add the functionality for the backends.

This addresses part of #47773, leaving the FFI class to the
FFI implementors.

Bug: https://github.com/47773
Change-Id: Id7ee0006b6ea5ed789867a143ee6266f6dbbef66
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/221502
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Lasse Nielsen <lrn@google.com>
@itsjustkevin
Copy link
Contributor

@lrhn this issue is marked as complete but not closed, are we still missing something here?

@mraleph mraleph closed this as completed Apr 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lrhn lrhn

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-core library-ffi type-task A well-defined stand-alone task
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mraleph @lrhn @itsjustkevin