Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor clarifications to Queue documentation. #479

Closed
DartBot opened this issue Nov 16, 2011 · 4 comments
Closed

Minor clarifications to Queue documentation. #479

DartBot opened this issue Nov 16, 2011 · 4 comments
Assignees
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue P3 A lower priority bug or feature request

Comments

@DartBot
Copy link

DartBot commented Nov 16, 2011

This issue was originally filed by alexey.v.var...@gmail.com


There are some (minor) gaps in the documentation of the corelib interface Queue: missing NPE specifications for some methods, etc.
Please see the attached patch.


Attachment:
queue.patch (1.11 KB)

@DartBot
Copy link
Author

DartBot commented Nov 17, 2011

This comment was originally written by drfibonacci@google.com


Removed Priority-Medium label.
Added Priority-Low, Area-Language, Triaged labels.

@DartBot
Copy link
Author

DartBot commented Nov 18, 2011

This comment was originally written by ngeoffray@google.com


Thanks for the patch Alexey. About NPEs, we should think more about how we want to address them. I'm not sure writing NPE specification on each method is the way to go.


Set owner to ngeoffray@google.com.
Removed Area-Language label.
Added Area-Library label.

@DartBot
Copy link
Author

DartBot commented Mar 20, 2012

This comment was originally written by ngeoffray@google.com


Handing off to Josh.


Set owner to jjb@google.com.

@lrhn
Copy link
Member

lrhn commented Mar 15, 2013

As Nicolas said, we don't want to say every place a null is not accepted. Instead we generally say it when a null is accepted, and then say what it means. In all other places, a null should be expected to give an error.


Set owner to @lrhn.
Added NotPlanned label.

@DartBot DartBot added Type-Defect P3 A lower priority bug or feature request area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue labels Mar 15, 2013
nex3 pushed a commit that referenced this issue Aug 31, 2016
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1803033002 .
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. closed-not-planned Closed as we don't intend to take action on the reported issue P3 A lower priority bug or feature request
Projects
None yet
Development

No branches or pull requests

2 participants