Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dartdev create web templates for Dart 3.0 support #51106

Closed
4 tasks done
nshahan opened this issue Jan 23, 2023 · 3 comments
Closed
4 tasks done

dartdev create web templates for Dart 3.0 support #51106

nshahan opened this issue Jan 23, 2023 · 3 comments
Assignees
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler

Comments

@nshahan
Copy link
Contributor

nshahan commented Jan 23, 2023

The integration test for creating a new Dart Web project is failing and currently skipped because it takes too long to timeout on the failure. #51037

I believe these are the steps remaining to get it working:

  • Publish build_web_compilers compatible with Dart 3.0.0-134.0.dev (already done v4.0.0).
  • Publish dwds compatible with Dart 3.0.0-134.0.dev.
  • Publish webdev compatible with dwds and build_web_compilers that are compatible with Dart 3.0.0-134.0.dev.
  • Update dartdev web template to depend on build_web_compilers: 4.0.0.
@nshahan nshahan added area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. labels Jan 23, 2023
@nshahan nshahan self-assigned this Jan 23, 2023
@nshahan
Copy link
Contributor Author

nshahan commented Jan 23, 2023

@annagrin I believe the list above should cover everything we need to fix the dart create web command.

@annagrin
Copy link
Contributor

@mit-mit @nshahan we need to publish a new version of webdev that works with current SDK. Here are the steps we normally follow to make sure the published package is properly tested:

  • roll dwds master internally, wait for a week to fix any issues encountered by the users
  • publish dwds
  • publish webdev

I tested the dart create web command with my local webdev installation and it works, so as soon as we publish webdev it should just start working.

Does this schedule sound acceptable for the fix?

@nshahan nshahan added the P1 A high priority bug; for example, a single project is unusable or has many test failures label Jan 27, 2023
@nshahan
Copy link
Contributor Author

nshahan commented Feb 1, 2023

The test is passing on linux and mac but failing on windows. Unfortunately the test output log is not very helpful. https://logs.chromium.org/logs/dart/buildbucket/cr-buildbucket/8790341062187901153/+/u/test_results/new_test_failures__logs_

Since the updates in the build and webdev packages were related to filenames and paths my only guess is that one of them isn't correct for windows. Still investigating.

@nshahan nshahan reopened this Feb 1, 2023
copybara-service bot pushed a commit that referenced this issue Feb 2, 2023
The test is still failing on windows only.
Skipping because the test takes too long to fail and deflake.

Issue: #51037
Issue: #51106
Change-Id: I804e4c7a4e378883943aa63816b71e6fe94de647
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280250
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-dart-cli Use area-dart-cli for issues related to the 'dart' command like tool. area-web Use area-web for Dart web related issues, including the DDC and dart2js compilers and JS interop. P1 A high priority bug; for example, a single project is unusable or has many test failures web-dev-compiler
Projects
None yet
Development

No branches or pull requests

3 participants