Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New vm/dart/gc/chunked_binary_trees_array_test timing out on a few configurations #52924

Closed
sstrickl opened this issue Jul 13, 2023 · 1 comment
Closed

New vm/dart/gc/chunked_binary_trees_array_test timing out on a few configurations #52924

sstrickl opened this issue Jul 13, 2023 · 1 comment
Assignees
@rmacnak-google
Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening

Comments

@sstrickl
Copy link
Contributor

There are new test failures on [vm, gc] Add flag to disable write barrier elimination..

The tests

vm/dart/gc/chunked_binary_trees_array_test/0 Timeout (expected Pass)
vm/dart/gc/chunked_binary_trees_array_test/1 Timeout (expected Pass)
vm/dart/gc/chunked_binary_trees_array_test/2 Timeout (expected Pass)
vm/dart/gc/chunked_binary_trees_array_test/3 Timeout (expected Pass)
vm/dart/gc/chunked_binary_trees_test/0 Timeout (expected Pass)
vm/dart/gc/chunked_binary_trees_test/1 Timeout (expected Pass)
vm/dart/gc/chunked_binary_trees_test/2 Timeout (expected Pass)
vm/dart/gc/chunked_binary_trees_test/3 Timeout (expected Pass)
vm/dart/gc/chunked_binary_trees_test/4 Timeout (expected Pass)
vm/dart/gc/chunked_binary_trees_test/5 Timeout (expected Pass)

are failing on configurations

vm-aot-android-release-arm_x64
vm-aot-linux-release-simarm_x64
vm-reload-linux-debug-x64

Specific list of which versions are failing on which configuration follows, including an example log for one of the versions:

/cc @rmacnak-google
@sstrickl sstrickl added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening labels Jul 13, 2023
copybara-service bot pushed a commit that referenced this issue Jul 13, 2023
@rmacnak-google
[test] Skip chunked_binary_trees tests on slower configurations.
327d425 
Bug: #52924
Change-Id: Iece24184411f1fdbc63903d893654c74aed3de55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313289
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
@a-siva a-siva closed this as completed Jul 13, 2023
osa1 pushed a commit to osa1/sdk that referenced this issue Jul 17, 2023
@rmacnak-google @osa1
[test] Skip chunked_binary_trees tests on slower configurations.
979adb2 
Bug: dart-lang#52924
Change-Id: Iece24184411f1fdbc63903d893654c74aed3de55
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/313289
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
@dcharkes dcharkes reopened this Nov 1, 2023
@dcharkes
Copy link
Contributor

dcharkes commented Nov 1, 2023 •
edited
Loading

This test is still timing out (and flakily so).

image

https://dart-current-results.web.app/#/filter=vm/dart/gc/chunked_binary_trees_test&showAll

All timing out configs are x64 debug. (Why would that config be slower?)

One config is now reliably timing out.

copybara-service bot pushed a commit that referenced this issue Nov 1, 2023
@rmacnak-google
[test] More systematically mark GC stress tests as slow.
27a2c2e 
Bug: #52924
Bug: #53551
Change-Id: Ic6470294a6f9f57b8c9e653cda1bc371d4902c88
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/333055
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rmacnak-google rmacnak-google

Labels
area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. gardening
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@sstrickl @dcharkes @rmacnak-google @a-siva