Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Desupport Windows 7 & 8 #54509

Open
4 of 5 tasks
mit-mit opened this issue Jan 3, 2024 · 9 comments
Open
4 of 5 tasks

Desupport Windows 7 & 8 #54509

mit-mit opened this issue Jan 3, 2024 · 9 comments
Assignees
@itsjustkevin
Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team

Comments

@mit-mit
Copy link
Member

mit-mit commented Jan 3, 2024 •
edited by a-siva

Dart's system requirements currently state that only Windows 10 & 11 are supported. However, we don't currently prevent the dart tool and the Dart VM from running on Windows 7 & 8, as a few Flutter customers were still using that support. The Flutter team is now considering increasing their minimum to Windows 10, so with that, we can go ahead and fully de-support Windows 7 & 8 in Dart too. See the linked Flutter issue for more details.

Work items

Once we've de-supported these older versions, we can take some steps to further clean up our code base:
@parlough parlough added area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. status-blocked Blocked from making progress by another (referenced) issue labels Jan 3, 2024
@brianquinlan
Copy link
Contributor

There are some path functions (e.g. PathCchRemoveFileSpec, PathCchCombineEx) that I'd like to use to make our symlink handling more robust on Windows. These functions are only available in Windows 8+.

@parlough parlough mentioned this issue Jan 3, 2024
Open
@mit-mit mit-mit mentioned this issue Jan 4, 2024
Closed
7 tasks
@a-siva a-siva added the P2 A bug or feature request we're likely to work on label Jan 5, 2024
@a-siva
Copy link
Contributor

a-siva commented Jan 5, 2024

Once flutter/flutter#140830 is done we can take this up.

@a-siva a-siva added the triaged Issue has been triaged by sub team label Jan 5, 2024
@mit-mit
Copy link
Member Author

mit-mit commented Feb 19, 2024 •
edited

This breaking change has been approved and announced, so you are clear to begin changes for this.

@mit-mit
Copy link
Member Author

mit-mit commented Feb 19, 2024

@itsjustkevin can you help with an announcement post on Dart Announce too (similar to the Flutter one you posted)?

@aam aam removed the status-blocked Blocked from making progress by another (referenced) issue label Feb 22, 2024
copybara-service bot pushed a commit that referenced this issue Feb 23, 2024
@rmacnak-google
[build] Set minimum version for Windows to 10.
74baf5e 
Bug: #54509
Change-Id: Ia52415c7eeea031dd0e8a27b6840b1e59b2baf6a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353786
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
copybara-service bot pushed a commit that referenced this issue Feb 23, 2024
@aam
[win/unwinding] Remove Windows7 handling of unwinding records API.
34213ba 
Bug: #54509
Change-Id: Ic88c864a1d9c0ef571576b4d39119ba3d0384135
TEST=ci
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353783
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
@aam
Copy link
Contributor

aam commented Jun 5, 2024

Check for minimum version was implemented via 74baf5e

@a-siva
Copy link
Contributor

a-siva commented Jun 5, 2024

https://dart-review.googlesource.com/c/sdk/+/369860 accounts for 'Remove IsWindows10OrGreater check '

@a-siva
Copy link
Contributor

a-siva commented Jun 5, 2024

@itsjustkevin the only issue left to be resolved is the announcement post on Dart Announce

@a-siva a-siva removed area-vm Use area-vm for VM related issues, including code coverage, and the AOT and JIT backends. labels Jun 5, 2024
copybara-service bot pushed a commit that referenced this issue Jun 5, 2024
@rmacnak-google
[vm, io] Remove dead Windows 7 code.
4227074 
TEST=ci
Bug: #54509
Change-Id: I488f01e43faccf6f9f2dd58fcd55ca33a7f1f55d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369860
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
@itsjustkevin
Copy link
Contributor

Thanks @a-siva ill cook something up tomorrow

@lrhn lrhn added the area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). label Jun 8, 2024
@ntkme ntkme mentioned this issue Jun 11, 2024
Closed
@mit-mit
Copy link
Member Author

mit-mit commented Jun 11, 2024

@itsjustkevin was this completed?

cleydyr added a commit to cleydyr/dart-sass-maven-plugin that referenced this issue Jun 12, 2024
@cleydyr
Update README.md
eb9e4da 
Add OS version deprecation warning (see dart-lang/sdk#54509)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@itsjustkevin itsjustkevin

Labels
area-tools A meta category for issues that should be addressed by tooling (prefer more concrete areas). P2 A bug or feature request we're likely to work on triaged Issue has been triaged by sub team
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
7 participants
@aam @lrhn @a-siva @brianquinlan @itsjustkevin @mit-mit @parlough