-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Desupport Windows 7 & 8 #54509
Comments
There are some path functions (e.g. PathCchRemoveFileSpec, PathCchCombineEx) that I'd like to use to make our symlink handling more robust on Windows. These functions are only available in Windows 8+. |
Once flutter/flutter#140830 is done we can take this up. |
This breaking change has been approved and announced, so you are clear to begin changes for this. |
@itsjustkevin can you help with an announcement post on Dart Announce too (similar to the Flutter one you posted)? |
Bug: #54509 Change-Id: Ia52415c7eeea031dd0e8a27b6840b1e59b2baf6a Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353786 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
Bug: #54509 Change-Id: Ic88c864a1d9c0ef571576b4d39119ba3d0384135 TEST=ci Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353783 Reviewed-by: Ryan Macnak <rmacnak@google.com> Commit-Queue: Alexander Aprelev <aam@google.com>
Check for minimum version was implemented via 74baf5e |
https://dart-review.googlesource.com/c/sdk/+/369860 accounts for 'Remove IsWindows10OrGreater check ' |
@itsjustkevin the only issue left to be resolved is the announcement post on Dart Announce |
TEST=ci Bug: #54509 Change-Id: I488f01e43faccf6f9f2dd58fcd55ca33a7f1f55d Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/369860 Reviewed-by: Alexander Aprelev <aam@google.com> Commit-Queue: Ryan Macnak <rmacnak@google.com>
Thanks @a-siva ill cook something up tomorrow |
@itsjustkevin was this completed? |
Add OS version deprecation warning (see dart-lang/sdk#54509)
Dart's system requirements currently state that only Windows 10 & 11 are supported. However, we don't currently prevent the
dart
tool and the Dart VM from running on Windows 7 & 8, as a few Flutter customers were still using that support. The Flutter team is now considering increasing their minimum to Windows 10, so with that, we can go ahead and fully de-support Windows 7 & 8 in Dart too. See the linked Flutter issue for more details.Work items
Once we've de-supported these older versions, we can take some steps to further clean up our code base:
IsWindows10OrGreater
check in https://github.com/dart-lang/sdk/blob/main/runtime/bin/eventhandler_win.cc#L155The text was updated successfully, but these errors were encountered: