Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CP] [dart2wasm] Remove experimental warning for dart compile wasm and make dart compile --help show the wasm subcommand #55857

Closed
mkustermann opened this issue May 28, 2024 · 4 comments
Closed

[CP] [dart2wasm] Remove experimental warning for dart compile wasm and make dart compile --help show the wasm subcommand #55857

mkustermann opened this issue May 28, 2024 · 4 comments
Assignees
@vsmenon @itsjustkevin @mit-mit @athomas
Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve

Comments

@mkustermann
Copy link
Member

Commit(s) to merge

004d6a3

Target

stable

Prepared changelist for beta/stable

https://dart-review.googlesource.com/c/sdk/+/368420

Issue Description

The dart compile wasm command is hidden and running it gives an experimental warning.

What is the fix

Make the dart compile wasm command public and remove the experimental warning.

Why cherry-pick

Avoids user confusion about us advertising dart2wasm as being stable but still issuing experimental warning

Risk

Low

Issue link(s)

#32894

Extra Info

No response
@mkustermann mkustermann added the cherry-pick-review Issue that need cherry pick triage to approve label May 28, 2024
@athomas
Copy link
Member

athomas commented May 28, 2024

LGTM

@athomas athomas added the cherry-pick-approved Label for approved cherrypick request label May 28, 2024
copybara-service bot pushed a commit that referenced this issue May 28, 2024
@mkustermann
[stable] [dart2wasm] Remove experimental warning for `dart compile wa…
ee66d5d 
…sm` and make `dart compile --help` show the wasm subcommand

Bug: #32894
Change-Id: Ia0d57385879630c9c4c289465c797b84444c36fc
Cherry-pick: https://dart-review.googlesource.com/c/sdk/+/368307
Cherry-pick-request: #55857
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/368420
Reviewed-by: Ömer Ağacan <omersa@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
@mkustermann
Copy link
Member Author

The CL landed on stable branch.

@mit-mit
Copy link
Member

mit-mit commented May 28, 2024

LGTM

@mit-mit mit-mit added the area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). label May 28, 2024
@athomas
Copy link
Member

athomas commented Jun 3, 2024

Released in 3.4.2.

@athomas athomas closed this as completed Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vsmenon vsmenon

@itsjustkevin itsjustkevin

@mit-mit mit-mit

@athomas athomas

Labels
area-meta Cross-cutting, high-level issues (for tracking many other implementation issues, ...). cherry-pick-approved Label for approved cherrypick request cherry-pick-review Issue that need cherry pick triage to approve
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@vsmenon @mkustermann @itsjustkevin @mit-mit @athomas