-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type checking of named arguments is wrong. #932
Comments
The implementation for type checking named arguments is bogus. This patch removes the symptom, but doesn't correctly implement type checking of named arguments. --- a/dart/compiler/java/com/google/dart/compiler/type/TypeAnalyzer.java
|
This comment was originally written by jimhug@google.com Frog handles this just fine - this is a dartc issue. Removed Area-Frog label. |
Set owner to @scheglov. |
Added Started label. |
Added Fixed label. |
2020-11-05 irina.arkhipets@gmail.com Fixes #602: New tests for least and greatest closures added. 2020-11-05 sgrekhov@unipro.ru #926. Rewrite io/Process/start_A01_t02 test to work on precompiled environment 2020-11-05 sgrekhov@unipro.ru #932. Rewrite HttpRequestUpload/onLoad_A01_t01 test to send correct HttpRequest 2020-11-04 sgrekhov@unipro.ru Fixes #956. Don't expect extension invocation on type dynamic 2020-11-04 karlklose@users.noreply.github.com Convert some multi-tests to static error framework (#958) 2020-11-03 irina.arkhipets@gmail.com Fixes #602: dynamic tests for least and greatest closures updated. 2020-11-03 irina.arkhipets@gmail.com Fixes #602: tests for least and greatest closures added. 2020-10-28 sgrekhov@unipro.ru #926. Fix two Process tests to use 'process_test' tool 2020-10-28 sgrekhov@unipro.ru #926. Rewrite two Process tests to use 'process_test' tool 2020-10-28 sgrekhov@unipro.ru Fixes #955. Expect less specific error for typed_data tests 2020-10-26 sgrekhov@unipro.ru Fixes #954. Change the line where we expect an error for CFE 2020-10-20 sgrekhov@unipro.ru Fixes #912. Abstract variables syntax tests added 2020-10-19 sgrekhov@unipro.ru #912. More external variables syntax tests added 2020-10-17 sgrekhov@unipro.ru External variables syntax test added 2020-10-16 sgrekhov@unipro.ru #912. More test for static analysis of external variables added 2020-10-15 sgrekhov@unipro.ru #912. Test for static analysis of external variables added 2020-10-14 sgrekhov@unipro.ru #912. Test for static analysis if abstract variables added Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,analyzer-nnbd-win-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try Change-Id: Id9cde784918faa4e891da8c4cb448d415a7a18aa Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170680 Reviewed-by: William Hesse <whesse@google.com> Commit-Queue: Alexander Thomas <athom@google.com>
2020-11-19 sgrekhov@unipro.ru #926.Add Platform.executableArguments to Process.run() command to not to fail on --enable-assert configuration 2020-11-19 sgrekhov@unipro.ru #926.Add Platform.executableArguments to Process.run() command to not to fail on --enable-assert configuration 2020-11-18 sgrekhov@unipro.ru Fixes #966. Move certificates to RawSecureServerSocket directory 2020-11-18 sgrekhov@unipro.ru #926. Fixed test that fail on precompiled environment in a strong mode 2020-11-17 sgrekhov@unipro.ru Fixes #951. Remove excessive @static-warning 2020-11-17 irina.arkhipets@gmail.com Fixes #946: LanguageFeatures/Instantiate-to-bound/nonfunction_typedef tests updated according to the SDK changes, missing tests added. 2020-11-17 sgrekhov@unipro.ru #932. Some HttpRequest tests fixed to work well with cross origin requests 2020-11-16 sgrekhov@unipro.ru Process kill test fixed to work on different platforms 2020-11-16 sgrekhov@unipro.ru External variable test that expects compile time error on dart2js added 2020-11-13 sgrekhov@unipro.ru Fixes #926. Remove "--enable-experiment=non-nullable" option from script that runs another process 2020-11-12 sgrekhov@unipro.ru #926. File lock checking tests rewritten to not to fail on precompiled environment. Second part 2020-11-12 irina.arkhipets@gmail.com Fixes #602: Missing issue tags added. 2020-11-11 sgrekhov@unipro.ru #926. File lock checking tests rewritten to not to fail on precompiled environment 2020-11-11 sgrekhov@unipro.ru Issue numbers added 2020-11-11 irina.arkhipets@gmail.com Fixes #963: test expected result corrected, test template for all generic typedefs updated. 2020-11-10 sgrekhov@unipro.ru #926. ProcessSignal tests rewritten to not to fail on precompiled environment 2020-11-10 sgrekhov@unipro.ru #926. Process tests rewritten to not to fail on precompiled environment 2020-11-10 sgrekhov@unipro.ru #961. Process tests rewritten to not to use process_test tool 2020-11-10 irina.arkhipets@gmail.com Fixes #602: Missing Issue tag added. 2020-11-10 sgrekhov@unipro.ru Fixes #960. Null safety execution modes renamed and mentions of obsolete checked mode removed 2020-11-10 sgrekhov@unipro.ru Remove wrong error expectations 2020-11-09 sgrekhov@unipro.ru Fixes #962. Change CFE error messages expectations 2020-11-08 irina.arkhipets@gmail.com Fixes #602: New tests for least and greatest closures added. Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-win-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try Change-Id: I7aff067ec96f762490de15daa20c40dff2b0ae96 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/172940 Reviewed-by: William Hesse <whesse@google.com>
2020-11-25 irina.arkhipets@gmail.com Fixes #968: missing testing options added back. 2020-11-25 sgrekhov@unipro.ru #969. Line numbers where we expect an error fixed 2020-11-25 sgrekhov@unipro.ru #969. Stdout tests failures on Windows fixed. Don't pass executable arguments to the Process 2020-11-24 irina.arkhipets@gmail.com Fixes #968: non-nullable shared option removed. 2020-11-23 sgrekhov@unipro.ru #932. HttpRequest tests fixed to work with cross origin 2020-11-20 sgrekhov@unipro.ru #926.Tryjob failures fixed Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try Change-Id: I32eaa75a0fcf4b5b7d8c4855b311a46948afb6f6 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/173964 Reviewed-by: William Hesse <whesse@google.com>
$ dartc fisk.dart
fisk.dart:4: int is not assignable to String
3: main() {
4: fisk(i: 1);
$ cat fisk.dart
fisk([String string, int i]) {}
main() {
fisk(i: 1);
}
The text was updated successfully, but these errors were encountered: