Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check up on socket close habdler and socket streams #941

Closed
sgjesse opened this issue Dec 22, 2011 · 4 comments
Closed

Check up on socket close habdler and socket streams #941

sgjesse opened this issue Dec 22, 2011 · 4 comments
Assignees
@sgjesse
Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io

Comments

@sgjesse
Copy link
Contributor

sgjesse commented Dec 22, 2011

Both the socket input stream and the socket output stream can register a close handler with a socket. However one will overwrite the other.

This needs to be looked at.
@sgjesse
Copy link
Contributor Author

sgjesse commented Feb 21, 2012

Removed Area-VM label.
Added Area-IO label.

@sgjesse
Copy link
Contributor Author

sgjesse commented Mar 21, 2012

The handling of the socket event callbacks in relation to streams should be OK now. The onClose callback is only hooked up by the input stream if used. Also exceptions are thrown if using both an input stream and onData/onClose events on the socket. The same goes for the output stream and the onWrite event.

Added Fixed label.

@DartBot
Copy link

DartBot commented Apr 7, 2013

This comment was originally written by amouravski@google.com

Removed Type-Review label.
Added Type-Defect label.

@kevmoo
Copy link
Member

kevmoo commented May 14, 2014

Removed Area-IO label.
Added Area-Library, Library-IO labels.

@sgjesse sgjesse added Type-Defect area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io labels May 14, 2014
@sgjesse sgjesse self-assigned this May 14, 2014
dart-bot pushed a commit that referenced this issue May 7, 2020
@eernstg
Adjust tests for new return rules, cf. language PR #941, #948.
2cc46ea 
The rules for returns with null-safety were changed in language PR #941,
and this PR makes changes to async/return_types_test.dart such that it
matches the new rules. Check base vs. patchset 1 to see these adjustments.

The main part of this PR is that it migrates and updates the tests
language/invalid_returns/{,a}sync_{,in}valid*_test.dart such
that they match the new rules. Check patchset 1 vs newest patchset
to see this migration.

Note that some tests are new, e.g., 'sync_invalid_return_27_test',
which was added because it is a new property that there is an error
for "return void to Null". Also note that some of the tests are
redundant: (1) It is no longer allowed to return void to Null, but
(2) that's an error already with null-safety, because it's a
downcast (so it doesn't matter which supertype of `Null` we have).
I kept these tests anyway (and even wrote this new one), because
they do check that certain changes have been implemented, even
though it is in some cases redundant in the sense that it's just
another verification that implicit downcasts aren't supported any
more. If we don't want this redundancy then we should remove about
10 tests (sync_invalid_return, async_invalid_return).

Change-Id: I3f10682e1d0ed75067d6e8651588b727ffd3648f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145587
Commit-Queue: Erik Ernst <eernst@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sgjesse sgjesse

Labels
area-core-library SDK core library issues (core, async, ...); use area-vm or area-web for platform specific libraries. library-io
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@kevmoo @sgjesse @DartBot