Fix issue with invoking main function from browser #55412
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
akalankavinda
changed the title
|
Thank you for your contribution! This project uses Gerrit for code reviews. Your pull request has automatically been converted into a code review at: https://dart-review.googlesource.com/c/sdk/+/361980 Please wait for a developer to review your code review at the above link; you can speed up the review if you sign into Gerrit and manually add a reviewer that has recently worked on the relevant code. See CONTRIBUTING.md to learn how to upload changes to Gerrit directly. Additional commits pushed to this PR will update both the PR and the corresponding Gerrit CL. After the review is complete on the CL, your reviewer will merge the CL (automatically closing this PR). |
|
@akalankavinda you are instantiating the Wasm module wrong. You should be using the instantiation function provided by the .mjs file. Here's a full example: <!DOCTYPE html>
<html>
<head>
<meta http-equiv="X-UA-Compatible" content="IE=edge">
<meta charset="utf-8">
<meta name="dart.unittest" content="full-stack-traces">
<title> test.dart.wasm </title>
<link rel="preload" href="/test.wasm" as="fetch" crossorigin>
</head>
<body>
<script type="module">
const dartModulePromise = WebAssembly.compileStreaming(fetch('/test.wasm'));
const imports = {};
let dart2wasm_runtime = await import('/test.mjs');
let moduleInstance =
await dart2wasm_runtime.instantiate(dartModulePromise, imports);
dart2wasm_runtime.invoke(moduleInstance);
</script>
</body>
</html>You can't instantiate the module yourself because you don't know what imports the module expects and how to provide them. Use the code above. If you really want to instantiate it yourself, you have to use the second overloading of Which returns "A |
|
Ah, sorry, you're already calling the instantiation function in the .mjs file, but it looks like the argument you're passing to it is the .wasm binary, but it should be a compiled module. If you call |
When trying to invoke main method the following error occurs.
this happens because of we store the result from
WebAssembly.instantiate(), which is a WebAssemblyInstantiatedSource type value. We should store the instance value inside the returned object