-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert the implementation of the action to Dart #77
Conversation
@joshualitt + @srujzs - can you review the js interop code (lib/node/*), the bootstrap script (lib/main.mjs), and anything else that looks interesting? Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The JS interop code looks great. I don't think there is anything that needs to change in this CL. One thing for us to ponder as team, there is some overlap in the JS interop used in this package and package:web
. It may make sense for us to publish a node interop package so we can share this work. Perhaps some of our users may also want to use such a package.
Anyway, food for thought. Regardless, that is far outside the scope of this CL.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM too!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, didn't review JS interop because people that know what they're doing already did :)
@@ -2,7 +2,12 @@ | |||
version: 2 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just curious, why no package-ecosystem: pub?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran into some issues when eval'ing it when it was in beta (dependabot/dependabot-core#4979), and was generally waiting for them to be addressed before using the functionality more widely.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! PR updated.
@@ -2,7 +2,12 @@ | |||
version: 2 | |||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran into some issues when eval'ing it when it was in beta (dependabot/dependabot-core#4979), and was generally waiting for them to be addressed before using the functionality more widely.
Convert the implementation of the action to Dart:
dart.yml
CI the same, so we could verify correct behavior of the portdart-version
1.5.0-dev