Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare shelf_web_socket 2.0 for release #425

Merged
merged 1 commit into from
May 6, 2024
Merged

Prepare shelf_web_socket 2.0 for release #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pkgs/shelf_web_socket/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
## 2.0.0-wip
## 2.0.0

* Require Dart `^3.0.0`.
* **BREAKING:**: Remove support for hijacking WebSocket requests that are not
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And this is good because we can delete a bunch of duplicate code, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is already deleted: dart-lang/web_socket_channel#341

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

but this work aligns with that work...hence why we're not as flexible?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. package:web_socket_channel has a partial copy of the dart:io WebSocket implementation that dart-lang/web_socket_channel#341 removes. The code was the cause of the recent security bug.

Expand Down
4 changes: 2 additions & 2 deletions pkgs/shelf_web_socket/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: shelf_web_socket
version: 2.0.0-wip
version: 2.0.0
description: >
A shelf handler that wires up a listener for every connection.
repository: https://github.com/dart-lang/shelf/tree/master/pkgs/shelf_web_socket
Expand All @@ -14,7 +14,7 @@ environment:
dependencies:
shelf: ^1.1.0
stream_channel: ^2.1.0
web_socket_channel: ^2.0.0
web_socket_channel: '>=2.0.0 <4.0.0'

dev_dependencies:
dart_flutter_team_lints: ^2.0.0
Expand Down