Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

async await codelab #1659

Merged
merged 51 commits into from
Aug 7, 2019
Merged

async await codelab #1659

merged 51 commits into from
Aug 7, 2019

Commits on Jun 4, 2019

  1. Add WIP async await codelab

    @legalcodes
    legalcodes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    7cf3303 View commit details
    Browse the repository at this point in the history

  2. Limit lines to 80 chars

    @legalcodes
    legalcodes committed Jun 4, 2019
    Configuration menu
    Copy the full SHA
    cd75e7f View commit details
    Browse the repository at this point in the history

Commits on Jun 5, 2019

  1. Round 1 of revisions: 

      - add futures codelab to sidenav
  - add futures codelab to /codelabs page
  - update 'url' global to dart.dev
  - move futures codelab to /codelabs/async-await (formerly incorrectly placed in /language)
  - sundry content corrections in futures codelab
    @legalcodes
    legalcodes committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    33a671b View commit details
    Browse the repository at this point in the history

  2. Add more updates per language comments/suggestions review feedback

    @legalcodes
    legalcodes committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    3934ee6 View commit details
    Browse the repository at this point in the history

  3. Further small updates addressing review comments.

    @legalcodes
    legalcodes committed Jun 5, 2019
    Configuration menu
    Copy the full SHA
    b34a5d7 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2019

  1. Configure site.alert templates and update futures codelab w/ templates

    @legalcodes
    legalcodes committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    b587b7f View commit details
    Browse the repository at this point in the history

  2. Add "Practicing" section iframe; slight restructure for "Errors" section

    @legalcodes
    legalcodes committed Jun 6, 2019
    Configuration menu
    Copy the full SHA
    7396cc6 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2019

  1. Added dartpad examples

    @legalcodes
    legalcodes committed Jun 10, 2019
    Configuration menu
    Copy the full SHA
    0e169e0 View commit details
    Browse the repository at this point in the history

Commits on Jun 11, 2019

  1. Remove extra title

    @legalcodes
    legalcodes committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    d2bafa7 View commit details
    Browse the repository at this point in the history

  2. Remove section head and use of "future object"

    @legalcodes
    legalcodes committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    846944c View commit details
    Browse the repository at this point in the history

  3. Remove typos

    @legalcodes
    legalcodes committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    60374bf View commit details
    Browse the repository at this point in the history

  4. Merge branch 'master' of https://github.com/dart-lang/site-www into f… 

    …uturesCodelab
    @legalcodes
    legalcodes committed Jun 11, 2019
    Configuration menu
    Copy the full SHA
    48f7c3a View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2019

  1. Punctuate all bulleted list items.

    @legalcodes
    legalcodes committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    0fd4ed2 View commit details
    Browse the repository at this point in the history

  2. Allow check-code to fail for dart dev builds

    @legalcodes
    legalcodes committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    4417dd9 View commit details
    Browse the repository at this point in the history

  3. Correct mistaken exclusion of check-code from builds

    @legalcodes
    legalcodes committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    11427cf View commit details
    Browse the repository at this point in the history

  4. Allow failure for check-code.sh

    @legalcodes
    legalcodes committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    a63570b View commit details
    Browse the repository at this point in the history

  5. Merge branch 'master' of https://github.com/dart-lang/site-www into f… 

    …uturesCodelab
    @legalcodes
    legalcodes committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    38b3d5b View commit details
    Browse the repository at this point in the history

  6. Allow failure for both check-code and analyze-and-test-examples

    @legalcodes
    legalcodes committed Jun 12, 2019
    Configuration menu
    Copy the full SHA
    5f9d525 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2019

  1. Updates per ux and tw review

    @legalcodes
    legalcodes committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    c0c98ae View commit details
    Browse the repository at this point in the history

  2. More updates per review from @sfshaza2

    @legalcodes
    legalcodes committed Jun 19, 2019
    Configuration menu
    Copy the full SHA
    5ff8fb1 View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2019

  1. Updates per latest sfshaza2 comments

    @legalcodes
    legalcodes committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    d18e711 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' of https://github.com/dart-lang/site-www into f… 

    …uturesCodelab
    @legalcodes
    legalcodes committed Jul 9, 2019
    Configuration menu
    Copy the full SHA
    71b621c View commit details
    Browse the repository at this point in the history

Commits on Jul 11, 2019

  1. Incorporate first part of changes from UX round 2

    @legalcodes
    legalcodes committed Jul 11, 2019
    Configuration menu
    Copy the full SHA
    0c92c5c View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2019

  1. Merge branch 'master' of https://github.com/dart-lang/site-www into f… 

    …uturesCodelab
    @legalcodes
    legalcodes committed Jul 15, 2019
    Configuration menu
    Copy the full SHA
    9d136d3 View commit details
    Browse the repository at this point in the history

Commits on Jul 16, 2019

  1. Correct typos, turn on latest DartPad UI, and misc small fxies

    @legalcodes
    legalcodes committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    3120d87 View commit details
    Browse the repository at this point in the history

  2. Update descriptions for examples

    @legalcodes
    legalcodes committed Jul 16, 2019
    Configuration menu
    Copy the full SHA
    123f576 View commit details
    Browse the repository at this point in the history

Commits on Jul 18, 2019

  1. Add updates from observing test user

    @legalcodes
    legalcodes committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    f67ffc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2019

  1. Minor update for example missing a border, extra sentence for DartPad

    @legalcodes
    legalcodes committed Jul 19, 2019
    Configuration menu
    Copy the full SHA
    5e5ec20 View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2019

  1. Re-organize introduction per latest feedback: 

    - Remove heading for introduction
- Remove DartPad example
- Eliminate "key terms" section
- Distribute key terms definitions across relevant portions codelab
    @legalcodes
    legalcodes committed Jul 20, 2019
    Configuration menu
    Copy the full SHA
    125f9a3 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2019

  1. Remove "!" characters from "Putting it all together" section

    @legalcodes
    legalcodes committed Jul 24, 2019
    Configuration menu
    Copy the full SHA
    4ee31a2 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2019

  1. Adding changes from latest review

    @legalcodes
    legalcodes committed Jul 30, 2019
    Configuration menu
    Copy the full SHA
    64dc921 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2019

  1. Refactored sync / async comparison section into 2 columns

    @legalcodes
    legalcodes committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    da8e3e3 View commit details
    Browse the repository at this point in the history

  2. Updated instructions before each example

    @legalcodes
    legalcodes committed Jul 31, 2019
    Configuration menu
    Copy the full SHA
    95a7ab7 View commit details
    Browse the repository at this point in the history

Commits on Aug 1, 2019

  1. Add changes before switching markup back to single-column view

    @legalcodes
    legalcodes committed Aug 1, 2019
    Configuration menu
    Copy the full SHA
    c151e1d View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2019

  1. Completed markup re-write

    @legalcodes
    legalcodes committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    86367c6 View commit details
    Browse the repository at this point in the history

  2. Finished updates from latest review comments

    @legalcodes
    legalcodes committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    d7b72c0 View commit details
    Browse the repository at this point in the history

  3. End with new lines for .travis.yml and .firebaserc

    @legalcodes
    legalcodes committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    0e6a5a9 View commit details
    Browse the repository at this point in the history

  4. Remove dartpad includes file, update nav per review comments

    @legalcodes
    legalcodes committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    cc371e2 View commit details
    Browse the repository at this point in the history

  5. Update codelab title

    @legalcodes
    legalcodes committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    60a0d36 View commit details
    Browse the repository at this point in the history

  6. Incorporate suggestions from latest review

    @legalcodes
    legalcodes committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    f48f067 View commit details
    Browse the repository at this point in the history

  7. Enforce 80 char line limit

    @legalcodes
    legalcodes committed Aug 2, 2019
    Configuration menu
    Copy the full SHA
    2c8c32f View commit details
    Browse the repository at this point in the history

Commits on Aug 5, 2019

  1. Small changes from latest review

    @legalcodes
    legalcodes committed Aug 5, 2019
    Configuration menu
    Copy the full SHA
    9621eb3 View commit details
    Browse the repository at this point in the history

Commits on Aug 6, 2019

  1. Updates from latest review

    @legalcodes
    legalcodes committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    e0aa7b8 View commit details
    Browse the repository at this point in the history

  2. Test omitting refresh-code-excerpts.sh - failing built

    @legalcodes
    legalcodes committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    f672a1a View commit details
    Browse the repository at this point in the history

  3. Remove test fix for build

    @legalcodes
    legalcodes committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    b2a44ce View commit details
    Browse the repository at this point in the history

  4. Some changes based on recent review

    @legalcodes
    legalcodes committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    cdda574 View commit details
    Browse the repository at this point in the history

  5. Incorporate latest review items

    @legalcodes
    legalcodes committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    37b6c04 View commit details
    Browse the repository at this point in the history

  6. Remove 'before running it'

    @legalcodes
    legalcodes committed Aug 6, 2019
    Configuration menu
    Copy the full SHA
    6624930 View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2019

  1. Exercise applies to "Working with futures"

    @legalcodes
    legalcodes committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    fb19d9c View commit details
    Browse the repository at this point in the history

  2. More updates - latest review

    @legalcodes
    legalcodes committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    f48d9c3 View commit details
    Browse the repository at this point in the history

  3. Add survey at the end of the codelab

    @legalcodes
    legalcodes committed Aug 7, 2019
    Configuration menu
    Copy the full SHA
    218c301 View commit details
    Browse the repository at this point in the history