Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some JS mentions from the language tour #4027

Merged
merged 2 commits into from
May 11, 2022

Conversation

parlough
Copy link
Member

@parlough parlough commented May 8, 2022

The language tour is not meant just for those that know JavaScript, especially when they can use the Learning Dart as a JavaScript developer article. This PR removes some of those JavaScript mentions to make the documentation more generic for other developers.

@parlough parlough requested a review from munificent May 8, 2022 19:34
@github-actions
Copy link

github-actions bot commented May 8, 2022

Visit the preview URL for this PR (updated for commit 008f3e3):

https://dart-dev--pr4027-feature-remove-js-me-slbqei1m.web.app

(expires Sun, 15 May 2022 19:46:39 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@parlough parlough merged commit 1560d30 into main May 11, 2022
@parlough parlough deleted the feature/remove-js-mentions branch May 11, 2022 15:13
Copy link
Member

@munificent munificent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants