Isolate examples documentation #5332
Conversation
|
Visit the preview URL for this PR (updated for commit 8c31560): https://dart-dev--pr5332-isolate-documentatio-wj7iadc7.web.app (expires Thu, 11 Jan 2024 14:09:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: d851bc446d3c4d7394c5406c6f07255afc7075f3 |
…late-documentation
…site-www into isolate-documentation
It's unfortunately a bit obscure right now. I guess the original thinking was that people would just run the I'm working on finalizing an updated version of the tool that is simpler to run and will provide some more details on what needs to be updated. Until then, let me know if you need me to run the tool. |
ericwindmill
changed the title
|
Not finished reviewing yet, but as part of this PR you should link to this new isolates page somewhere on the Concurrency page. I suggest the end of the first paragraph (and you can fix the typo there too):
|
|
Visit the preview URL for this PR (updated for commit 8c31560): https://dart-dev--pr5332-isolate-documentation-axfgpc3r.web.app |
Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
|
@johnpryan, @lrhn, @domesticmouse, can one of you please review the ports code examples? Most importantly examples/concurrency/lib/robust_ports_example/complete.dart |
| final ReceivePort _responses; | ||
| // #enddocregion constructor | ||
| static Future<Worker> spawn() async { | ||
| // Create a receive port and add it's initial message handler |
This PR fixes typos introduced in #5332 --- Co-authored-by: Parker Lougheed <parlough@gmail.com>
This is the first PR of two that will update isolate documentation. It was decided that we should split [the original PR](dart-lang#5332) into two. This PR updates documentation at language/concurrency with more information. Fixes dart-lang#3720 --- - [x] I’ve reviewed the contributor guide and applied the relevant portions to this PR. - [x] This PR doesn’t contain automatically generated corrections or text (Grammarly, LLMs, and similar). - [x] This PR follows the [Google Developer Documentation Style Guidelines](https://developers.google.com/style) — for example, it doesn’t use _i.e._ or _e.g._, and it avoids _I_ and _we_ (first person). - [x] This PR uses [semantic line breaks](https://github.com/dart-lang/site-shared/blob/main/doc/writing-for-dart-and-flutter-websites.md#semantic-line-breaks) of 80 characters or fewer. --------- Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com> Co-authored-by: Parker Lougheed <parlough@gmail.com>
This PR is being split into two. The first one can be found [here](dart-lang#5402). This PR updates documentation at language/concurrency with more information, and adds a page language/isolates with examples. Fixes dart-lang#3720 **Staged:** - [Concurrency](https://dart-dev--pr5332-isolate-documentatio-gmqcme0e.web.app/language/concurrency) _(Updated)_ - [Isolates](https://dart-dev--pr5332-isolate-documentatio-gmqcme0e.web.app/language/isolates) _(New)_ --------- Co-authored-by: Parker Lougheed <parlough@gmail.com> Co-authored-by: Marya <111139605+MaryaBelanger@users.noreply.github.com>
This PR fixes typos introduced in dart-lang#5332 --- Co-authored-by: Parker Lougheed <parlough@gmail.com>
This PR is being split into two. The first one can be found here.
This PR updates documentation at language/concurrency with more information, and adds a page language/isolates with examples.
Fixes #3720
Staged: