package:web migration page
#5524
Conversation
|
Visit the preview URL for this PR (updated for commit de463ad): |
| ```dart | ||
| _clickSubscription = window.onClick.listen(callback); // Remove | ||
| window.onclick = callback.toJS; // Add | ||
| ``` |
There was a problem hiding this comment.
This example is from a doc written before the helper methods became a thing. I'm guessing technically there's a helper to address this kind of thing now, so maybe a bad example?
There was a problem hiding this comment.
There is, although the helpers are on Element, but yeah, I think the example is probably not what we want. We can put a TODO here to look at some of the migrations and look for a better example.
| ```dart | ||
| _clickSubscription = window.onClick.listen(callback); // Remove | ||
| window.onclick = callback.toJS; // Add | ||
| ``` |
There was a problem hiding this comment.
There is, although the helpers are on Element, but yeah, I think the example is probably not what we want. We can put a TODO here to look at some of the migrations and look for a better example.
| automatic binding of async callbacks in the current zone. | ||
|
|
||
| To migrate, you can still to use zones, | ||
| but you will have to [write them yourself][zones]. |
There was a problem hiding this comment.
TODO on me to come up with an example.
|
@srujzs I added a rough draft of the comparison section. I'll definitely go over it again to improve the wording, but just want to get it out so you could take a look. Mostly wondering if that's the kind of content you had in mind. Thanks! |
Does the following: - Adds sections about virtual dispatch, conditional imports, and zones - Rewords sections and headers to be a bit more accurate wrt naming - Adds more context on renames and type checks - Fixes old conditional import code
|
Thanks for the edits Marya! I went through and added a few edits (the commit message should contain a summary) and additional sections. From my perspective, this is good to go. cc @sigmundch for a review. I'll tackle any comments in another PR instead so this can be unblocked. |
Co-authored-by: sigmundch <sigmund@google.com>
This is a very high level migration page that mostly points to JS interop pages and the
webrepo for more detail.Part of #4578