Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run package:test tests on mac #2280

Merged
merged 4 commits into from
Sep 11, 2024
Merged

Run package:test tests on mac #2280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
3bca98a
Run package:test tests on mac
natebosch Sep 10, 2024
2274bfd
Skip safari tests
natebosch Sep 10, 2024
ca4e649
Skip firefox tests on mac
natebosch Sep 10, 2024
2eb0a2c
Skip another safari test
natebosch Sep 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
208 changes: 199 additions & 9 deletions .github/workflows/dart.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

5 changes: 5 additions & 0 deletions pkgs/test/mono_pkg.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,25 +22,30 @@ stages:
- command: dart test --preset travis --total-shards 5 --shard-index 0
os:
- windows
- osx
sdk:
- pubspec
- command: dart test --preset travis --total-shards 5 --shard-index 1
os:
- windows
- osx
sdk:
- pubspec
- command: dart test --preset travis --total-shards 5 --shard-index 2
os:
- windows
- osx
sdk:
- pubspec
- command: dart test --preset travis --total-shards 5 --shard-index 3
os:
- windows
- osx
sdk:
- pubspec
- command: dart test --preset travis --total-shards 5 --shard-index 4
os:
- windows
- osx
sdk:
- pubspec
6 changes: 4 additions & 2 deletions pkgs/test/test/runner/browser/safari_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,8 @@ import 'code_server.dart';
void main() {
setUpAll(precompileTestExecutable);

test('starts Safari with the given URL', () async {
test('starts Safari with the given URL',
skip: 'https://github.com/dart-lang/test/issues/1253', () async {
var server = await CodeServer.start();

server.handleJavaScript('''
Expand Down Expand Up @@ -54,7 +55,8 @@ webSocket.addEventListener("open", function() {
startsWith('Failed to run Safari: $noSuchFileMessage'))));
});

test('can run successful tests', () async {
test('can run successful tests',
skip: 'https://github.com/dart-lang/test/issues/1253', () async {
await d.file('test.dart', '''
import 'package:test/test.dart';

Expand Down
21 changes: 13 additions & 8 deletions pkgs/test/test/runner/compiler_runtime_matrix_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,19 @@ void main() {
(runtime == Runtime.safari && !Platform.isMacOS)) {
continue;
}
String? skipReason;
if (runtime == Runtime.safari) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really want to nerd snipe you to make this a switch, but don't fall for it!

skipReason = 'https://github.com/dart-lang/test/issues/1253';
} else if (compiler == Compiler.dart2wasm) {
skipReason = 'Wasm tests are experimental and require special setup';
} else if ([Runtime.firefox, Runtime.nodeJS].contains(runtime) &&
Platform.isWindows) {
skipReason = 'https://github.com/dart-lang/test/issues/1942';
} else if (runtime == Runtime.firefox && Platform.isMacOS) {
skipReason = 'https://github.com/dart-lang/test/pull/2276';
}
group('--runtime ${runtime.identifier} --compiler ${compiler.identifier}',
() {
skip: skipReason, () {
final testArgs = [
'test.dart',
'-p',
Expand Down Expand Up @@ -112,13 +123,7 @@ void main() {
? 'https://github.com/dart-lang/test/issues/2150'
: null);
}
},
skip: compiler == Compiler.dart2wasm
? 'Wasm tests are experimental and require special setup'
: [Runtime.firefox, Runtime.nodeJS].contains(runtime) &&
Platform.isWindows
? 'https://github.com/dart-lang/test/issues/1942'
: null);
});
}
}
}
Expand Down