Skip to content

Commit

Permalink
[DWDS] Account for the optional parameters that will be added in pack…
Browse files Browse the repository at this point in the history
…age:vm_service_interface 2.0.0 (#2490)

This is needed to land the SDK CL that checks in package:vm_service_interface 2.0.0, because this is needed to make the g3-cbuild-try job pass.
  • Loading branch information
derekxu16 authored Sep 4, 2024
1 parent 3deaa0c commit 8156106
Show file tree
Hide file tree
Showing 2 changed files with 37 additions and 5 deletions.
1 change: 1 addition & 0 deletions dwds/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
- Spawn DDS in a separate process using `dart development-service` instead of launching from `package:dds`. - [#2466](https://github.com/dart-lang/webdev/pull/2466)
- Update package `web_socket_channel: '>=2.2.0 <4.0.0'`.
- Require Dart `^3.4`
- Prepare to update `package:vm_service_interface` constraint to `2.0.0`.

## 24.0.0

Expand Down
41 changes: 36 additions & 5 deletions dwds/lib/src/services/chrome_proxy_service.dart
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
Map<String, String>? scope,
// TODO(798) - respect disableBreakpoints.
bool? disableBreakpoints,

/// Note that `idZoneId` arguments will be ignored. This parameter is only
/// here to make this method is a valid override of
/// [VmServiceInterface.evaluate].
String? idZoneId,
}) =>
wrapInErrorHandlerAsync(
'evaluate',
Expand Down Expand Up @@ -716,6 +721,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
Map<String, String>? scope,
// TODO(798) - respect disableBreakpoints.
bool? disableBreakpoints,

/// Note that `idZoneId` arguments will be ignored. This parameter is only
/// here to make this method is a valid override of
/// [VmServiceInterface.evaluateInFrame].
String? idZoneId,
}) =>
wrapInErrorHandlerAsync(
'evaluateInFrame',
Expand Down Expand Up @@ -805,6 +815,7 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
int limit, {
bool? includeImplementers,
bool? includeSubclasses,
String? idZoneId,
}) {
return _rpcNotSupportedFuture('getInstances');
}
Expand Down Expand Up @@ -845,6 +856,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
String objectId, {
int? offset,
int? count,

/// Note that `idZoneId` arguments will be ignored. This parameter is only
/// here to make this method is a valid override of
/// [VmServiceInterface.getObject].
String? idZoneId,
}) =>
wrapInErrorHandlerAsync(
'getObject',
Expand Down Expand Up @@ -946,7 +962,15 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
///
/// The returned stack will contain up to [limit] frames if provided.
@override
Future<Stack> getStack(String isolateId, {int? limit}) =>
Future<Stack> getStack(
String isolateId, {
int? limit,

/// Note that `idZoneId` arguments will be ignored. This parameter is only
/// here to make this method is a valid override of
/// [VmServiceInterface.getStack].
String? idZoneId,
}) =>
wrapInErrorHandlerAsync(
'getStack',
() => _getStack(isolateId, limit: limit),
Expand Down Expand Up @@ -1002,6 +1026,11 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
List argumentIds, {
// TODO(798) - respect disableBreakpoints.
bool? disableBreakpoints,

/// Note that `idZoneId` arguments will be ignored. This parameter is only
/// here to make this method is a valid override of
/// [VmServiceInterface.invoke].
String? idZoneId,
}) =>
wrapInErrorHandlerAsync(
'invoke',
Expand Down Expand Up @@ -1591,17 +1620,19 @@ ${globalToolConfiguration.loadStrategy.loadModuleSnippet}("dart_sdk").developer.
Future<InboundReferences> getInboundReferences(
String isolateId,
String targetId,
int limit,
) {
int limit, {
String? idZoneId,
}) {
return _rpcNotSupportedFuture('getInboundReferences');
}

@override
Future<RetainingPath> getRetainingPath(
String isolateId,
String targetId,
int limit,
) {
int limit, {
String? idZoneId,
}) {
return _rpcNotSupportedFuture('getRetainingPath');
}

Expand Down

0 comments on commit 8156106

Please sign in to comment.