updated strategy providers to allow clients to specify package config…

… path
dart-lang · Feb 5, 2025 · adc54a6 · adc54a6
1 parent 720b74b
commit adc54a6
Show file tree

Hide file tree

Showing 6 changed files with 30 additions and 19 deletions.
diff --git a/dwds/CHANGELOG.md b/dwds/CHANGELOG.md
@@ -1,6 +1,6 @@
 ## 24.3.4
 
-- Ensure `packageConfigPath` is initialized in `LoadStrategy` at construction.
+- Allow clients to specify the `packageConfigPath` in `LoadStrategy` class and associated providers.
 - Added support for some debugging APIs with the DDC library bundle format. - [#2566](https://github.com/dart-lang/webdev/issues/2566), [#2573](https://github.com/dart-lang/webdev/issues/2573)
 - Added support for hot reload using the DDC library bundle format.
 

diff --git a/dwds/lib/src/loaders/build_runner_require.dart b/dwds/lib/src/loaders/build_runner_require.dart
@@ -22,6 +22,7 @@ class BuildRunnerRequireStrategyProvider {
   final ReloadConfiguration _configuration;
   final AssetReader _assetReader;
   final BuildSettings _buildSettings;
+  final String? _packageConfigPath;
 
   late final RequireStrategy _requireStrategy = RequireStrategy(
     _configuration,
@@ -34,14 +35,16 @@ class BuildRunnerRequireStrategyProvider {
     _moduleInfoForProvider,
     _assetReader,
     _buildSettings,
+    packageConfigPath: _packageConfigPath,
   );
 
   BuildRunnerRequireStrategyProvider(
     this._assetHandler,
     this._configuration,
     this._assetReader,
-    this._buildSettings,
-  );
+    this._buildSettings, {
+    String? packageConfigPath,
+  }) : _packageConfigPath = packageConfigPath;
 
   RequireStrategy get strategy => _requireStrategy;
 

diff --git a/dwds/lib/src/loaders/ddc.dart b/dwds/lib/src/loaders/ddc.dart
@@ -141,9 +141,9 @@ class DdcStrategy extends LoadStrategy {
     this._moduleInfoForProvider,
     AssetReader assetReader,
     this._buildSettings,
-    this._g3RelativePath,
+    this._g3RelativePath, {
     String? packageConfigPath,
-  ) : super(assetReader, packageConfigPath: packageConfigPath);
+  }) : super(assetReader, packageConfigPath: packageConfigPath);
 
   @override
   Handler get handler => (request) async {

diff --git a/dwds/lib/src/loaders/ddc_library_bundle.dart b/dwds/lib/src/loaders/ddc_library_bundle.dart
@@ -111,9 +111,9 @@ class DdcLibraryBundleStrategy extends LoadStrategy {
     this._moduleInfoForProvider,
     AssetReader assetReader,
     this._buildSettings,
-    this._g3RelativePath,
+    this._g3RelativePath, {
     String? packageConfigPath,
-  ) : super(assetReader, packageConfigPath: packageConfigPath);
+  }) : super(assetReader, packageConfigPath: packageConfigPath);
 
   @override
   Handler get handler => (request) async {

diff --git a/dwds/lib/src/loaders/frontend_server_strategy_provider.dart b/dwds/lib/src/loaders/frontend_server_strategy_provider.dart
@@ -18,14 +18,17 @@ abstract class FrontendServerStrategyProvider<T extends LoadStrategy> {
   final Future<Map<String, String>> Function() _digestsProvider;
   final String _basePath;
   final BuildSettings _buildSettings;
+  final String? _packageConfigPath;
 
   FrontendServerStrategyProvider(
     this._configuration,
     this._assetReader,
     this._packageUriMapper,
     this._digestsProvider,
-    this._buildSettings,
-  ) : _basePath = _assetReader.basePath;
+    this._buildSettings, {
+    String? packageConfigPath,
+  })  : _basePath = _assetReader.basePath,
+        _packageConfigPath = packageConfigPath;
 
   T get strategy;
 
@@ -118,16 +121,17 @@ class FrontendServerDdcStrategyProvider
     _assetReader,
     _buildSettings,
     (String _) => null,
-    null,
+    packageConfigPath: _packageConfigPath,
   );
 
   FrontendServerDdcStrategyProvider(
     super._configuration,
     super._assetReader,
     super._packageUriMapper,
     super._digestsProvider,
-    super._buildSettings,
-  );
+    super._buildSettings, {
+    super.packageConfigPath,
+  });
 
   @override
   DdcStrategy get strategy => _ddcStrategy;
@@ -150,16 +154,17 @@ class FrontendServerDdcLibraryBundleStrategyProvider
     _assetReader,
     _buildSettings,
     (String _) => null,
-    null,
+    packageConfigPath: _packageConfigPath,
   );
 
   FrontendServerDdcLibraryBundleStrategyProvider(
     super._configuration,
     super._assetReader,
     super._packageUriMapper,
     super._digestsProvider,
-    super._buildSettings,
-  );
+    super._buildSettings, {
+    super.packageConfigPath,
+  });
 
   @override
   DdcLibraryBundleStrategy get strategy => _libraryBundleStrategy;
@@ -179,15 +184,17 @@ class FrontendServerRequireStrategyProvider
     _moduleInfoForProvider,
     _assetReader,
     _buildSettings,
+    packageConfigPath: _packageConfigPath,
   );
 
   FrontendServerRequireStrategyProvider(
     super._configuration,
     super._assetReader,
     super._packageUriMapper,
     super._digestsProvider,
-    super._buildSettings,
-  );
+    super._buildSettings, {
+    super.packageConfigPath,
+  });
 
   @override
   RequireStrategy get strategy => _requireStrategy;

diff --git a/dwds/lib/src/loaders/require.dart b/dwds/lib/src/loaders/require.dart
@@ -137,8 +137,9 @@ class RequireStrategy extends LoadStrategy {
     this._serverPathForAppUri,
     this._moduleInfoForProvider,
     AssetReader assetReader,
-    this._buildSettings,
-  ) : super(assetReader);
+    this._buildSettings, {
+    String? packageConfigPath,
+  }) : super(assetReader, packageConfigPath: packageConfigPath);
 
   @override
   Handler get handler => (request) async {