Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DWDS error handling should align better with vm_service's error handling #2140

Closed
elliette opened this issue Jun 12, 2023 · 1 comment · Fixed by #2144
Closed

DWDS error handling should align better with vm_service's error handling #2140

elliette opened this issue Jun 12, 2023 · 1 comment · Fixed by #2144
Labels
package:dwds

Comments

@elliette
Copy link
Contributor

Context:

DWDS doesn't always return an exception of type RPCError (defining in package:vm_service) when something goes wrong, which means that clients expecting an RPCError don't catch the exceptions thrown by DWDS.

We should make sure that DWDS returns semantic exceptions for all the API methods in chrome_proxy_service. This will require updating package:vm_service to expose all the error codes (including those currently defined in DDS and not exposed).
@elliette
Copy link
Contributor Author

Note: error codes from DDS were exposed in dart-lang/sdk@66ded0c

This was referenced Jun 12, 2023
Merged
Merged
auto-submit bot pushed a commit that referenced this issue Jun 16, 2023
@elliette
Wrap VM service API methods in an error handler to convert any except…
1551fe6 
…ions into type `RPCError` (#2144)

Fixes #2140, work towards flutter/flutter#126362
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:dwds
Projects
None yet
Milestone
No milestone
1 participant
@elliette