Remove unnecessary awaits #1982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 13 commits
January 27, 2023 12:02
|
@natebosch I hope I got the idea right on where asyncs/awaits can be safely removed. Appreciate a review! |
annagrin
commented
Feb 22, 2023
| @@ -2,7 +2,6 @@ | |||
| // for details. All rights reserved. Use of this source code is governed by a | |||
| // BSD-style license that can be found in the LICENSE file. | |||
|
|
|||
| import 'dart:async'; | |||
There was a problem hiding this comment.
I wonder why the analyzer does not catch those...
There was a problem hiding this comment.
Hmm, it should
https://dart.dev/tools/diagnostic-messages#unnecessary_import
@srawlins - do you know why these aren't flagged?
There was a problem hiding this comment.
Not offhand. I've seen unnecessary_import call out other dart:async imports.
annagrin
commented
Feb 22, 2023
| @@ -1,6 +1,6 @@ | |||
| // Copyright (c) 2019, the Dart project authors. Please see the AUTHORS file | |||
| // for details. All rights reserved. Use of this source code is governed by a | |||
| // BSD-style license that can be found in the LICENSE file.import 'dart:async'; | |||
There was a problem hiding this comment.
looks like accidental change propagated by copy and paste in places:)
natebosch
approved these changes
Feb 22, 2023
| @@ -2,7 +2,6 @@ | |||
| // for details. All rights reserved. Use of this source code is governed by a | |||
| // BSD-style license that can be found in the LICENSE file. | |||
|
|
|||
| import 'dart:async'; | |||
There was a problem hiding this comment.
Hmm, it should
https://dart.dev/tools/diagnostic-messages#unnecessary_import
@srawlins - do you know why these aren't flagged?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove unnecessary awaits and async keywords.