Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor record shape processing out of calculating record bound fields #2074

Merged
merged 4 commits into from
Apr 10, 2023

Conversation

annagrin
Copy link
Contributor

@annagrin annagrin commented Apr 5, 2023

Record shapes can be used in other places such as RecordTypes. Refactor the code for record shape processing out of code calculating record bound fields so we can potentially reuse it for RecordTypes.

See: #2070

@annagrin annagrin requested a review from elliette April 5, 2023 18:34
@annagrin annagrin changed the title Refactor record shape processing our of calculating record bound fields Refactor record shape processing out of calculating record bound fields Apr 5, 2023
@elliette elliette merged commit 843890c into dart-lang:master Apr 10, 2023
function() {
var sdkUtils = ${globalLoadStrategy.loadModuleSnippet}('dart_sdk').dart;
var shape = sdkUtils.dloadRepl(this, "shape");
var positionalCount = sdkUtils.dloadRepl(shape, "positionals");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why are the Repl versions of these dload calls used? The repl and regular versions should be identical because the fields are not private but it appears we are using the wrong version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants