Plumbing flags required for running tests with the DDC module system. #2295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Markzipan
commented
Dec 1, 2023
annagrin
suggested changes
Dec 4, 2023
annagrin
suggested changes
Dec 6, 2023
annagrin
suggested changes
Dec 8, 2023
dwds/test/fixtures/context.dart
Outdated
| target: project.directoryToServe, | ||
| buildResults: buildResults, | ||
| chromeConnection: () async => connection, | ||
| autoRun: testSettings.autoRun, | ||
| completeBeforeHandlingConnections: tabConnectionCompleter.future, |
There was a problem hiding this comment.
I am curious about the exact details here (given that the plumbing changes the interface and will need a major version update) - could you please add more information on what exactly is the set of events and how it hangs? Also adding the comments in code so we can avoid this in the future.
annagrin
suggested changes
Dec 12, 2023
There was a problem hiding this comment.
Thank @Markzipan, this is looking good! lets fix some minor things and add a couple of tests (I left comments).
annagrin
suggested changes
Dec 13, 2023
There was a problem hiding this comment.
Thanks @Markzipan, just a few things I missed plus an ask for one more test.
|
Looks good! Let's sync and make sure tests are passing. |
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Feb 24, 2024
…#141423) ### Context: DDC modules are abstractions over how libraries are loaded/updated. The entirety of google3 uses the DDC/legacy module system due to its flexibility extensibility over the other two (ES6 and AMD/RequireJS). Unifying DDC's module system saves us from duplicating work and will allow us to have finer grained control over how JS modules are loaded. This is a a prerequisite to features such as hot reload. ### Overview: This change plumbs a boolean flag through flutter_tools that switches between DDC (new) and AMD (current) modules. This mode is automatically applied when `--extra-front-end-options=--dartdevc-module-format=ddc` is specified alongside `flutter run`. Other important additions include: * Splitting Flutter artifacts between DDC and AMD modules * Adding unit tests for the DDC module system * Additional bootstrapper logic for the DDC module system We don't expect to see any user-visible behavior or performance differences. This is dependent on [incoming module system support in DWDS](dart-lang/webdev#2295) and [additional artifacts in the engine](flutter/engine#47783). This is part of a greater effort to deprecate the AMD module system: dart-lang/sdk#52361
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Besides passing flags, this change includes:
Future.delayed(someDuration)just beforegetTab).This change requires the updated DDC Module Loader API to be landed first in the SDK (see this change).
This is part of a greater effort to deprecate the AMD module system: dart-lang/sdk#52361