Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Filter out internal type properties from the new DDC type system #2348

Merged
merged 5 commits into from
Jan 19, 2024
Merged

Filter out internal type properties from the new DDC type system #2348

merged 5 commits into from
Jan 19, 2024

Conversation

elliette
Copy link
Contributor

Fixes #2316, #2340

Filter out internal type representations and type fields from the new DDC type system.

@elliette elliette changed the title Filter out RTI objects Filter out internal type properties from the new DDC type system Jan 18, 2024
nshahan
nshahan reviewed Jan 18, 2024
View reviewed changes
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of our discussion, this LGTM if we add a use of the T type variable in the fixture used in the tests were we expect to filter it out.

nshahan
nshahan approved these changes Jan 19, 2024
View reviewed changes
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@elliette elliette merged commit 0c4d9e5 into dart-lang:master Jan 19, 2024
47 checks passed
This was referenced Jan 23, 2024
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nshahan nshahan nshahan approved these changes

@annagrin annagrin Awaiting requested review from annagrin

@Markzipan Markzipan Awaiting requested review from Markzipan

Assignees
No one assigned
Labels
package:dwds
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter out type generic for Classes with new DDC type system
2 participants
@elliette @nshahan