Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Renaming "legacy" paths and DDC modules to "DDC" paths and modules. #2360

Merged
merged 6 commits into from
Feb 2, 2024

Conversation

Markzipan
Copy link
Contributor

This aligns our naming scheme for the DDC module system.

See related change in the SDK: https://dart-review.googlesource.com/c/sdk/+/348183

This is part of a greater effort to deprecate the AMD module system: dart-lang/sdk#52361

@Markzipan Markzipan requested a review from elliette January 30, 2024 18:32
@parlough
Copy link
Member

Thanks for working on this large renaming/standardization effort across the board @Markzipan! Will make everything much easier to follow and understand =]

Copy link
Contributor

@elliette elliette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM but looks like the tests need to updated as well!

@Markzipan
Copy link
Contributor Author

Markzipan commented Jan 31, 2024

Thanks for reviewing! I missed client.js

@Markzipan Markzipan merged commit 629c632 into dart-lang:master Feb 2, 2024
47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants