Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not persist breakpoints across hot restarts or page refreshes #2371

Merged
merged 20 commits into from
Feb 26, 2024

Conversation

elliette
Copy link
Contributor

@elliette elliette commented Feb 5, 2024

Fixes #2257

  • Use setBreakpoint instead of setBreakpointByUrl. When breakpoints are set with the setBreakpoint API, Chrome will not try to persist breakpoints across page reloads. This was causing an issue where Chrome might still be hanging onto a breakpoint that didn't exist in the debugging client.
  • Remove the logic to try to re-establish breakpoints after a page reload. This is not what the VM service does. Instead, the debugging client should be in charge of re-establishing the breakpoints.

See go/dart-web-phantom-breakpoints for more details

@elliette elliette changed the title Use setBreakpoints instead of setBreakpointsByUrl Do not persist breakpoints across hot restarts or page refreshes Feb 6, 2024
@elliette elliette requested a review from nshahan February 6, 2024 22:57
Copy link
Contributor

@nshahan nshahan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elliette
Copy link
Contributor Author

elliette commented Feb 26, 2024

Submitting with failing frontend_server_client_test. Failure is unrelated to this change, should be fixed with #2376

@elliette elliette merged commit c29e5f8 into dart-lang:master Feb 26, 2024
46 of 47 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hot restart and breakpoints
2 participants