Make pauseIsolatesOnStart an optional parameter to hot-restart
#2397
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nshahan
approved these changes
Mar 26, 2024
| hotRestartJs = allowInterop((String runId, bool pauseIsolatesOnStart) { | ||
| if (pauseIsolatesOnStart) { | ||
| hotRestartJs = allowInterop((String runId, [bool? pauseIsolatesOnStart]) { | ||
| if (pauseIsolatesOnStart ?? false) { |
There was a problem hiding this comment.
Is this preferable to giving it a default value?
There was a problem hiding this comment.
We also define @JS(r'$dartHotRestartDwds') somewhere else (in google3) and this way we don't need to update the parameters there too. I'm not sure if we would if this had a default value.
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #2378
The
pauseIsolatesOnStartparameter should be optional, so that we don't need to update all the call sites at once.Work towards flutter/devtools#7231