Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AliasError -> AliasException #57

Merged
merged 2 commits into from
Sep 28, 2023
Merged

AliasError -> AliasException #57

merged 2 commits into from
Sep 28, 2023

Conversation

sigurdm
Copy link
Contributor

@sigurdm sigurdm commented Sep 28, 2023 •
edited
Loading

It is very hard/impossible to protect against aliases in the input up front, therefore it should be possible to catch and handle this.

This would allow us to give a good error message in: dart-lang/pub#3591

szakarias
szakarias approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@szakarias szakarias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sigurdm sigurdm merged commit 8a380e8 into dart-lang:main Sep 28, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devoncarew devoncarew devoncarew left review comments

@szakarias szakarias szakarias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sigurdm @devoncarew @szakarias