Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gas/simple fee market #147

Closed
wants to merge 4 commits into from
Closed

gas/simple fee market #147

wants to merge 4 commits into from

Conversation

hujw77
Copy link
Collaborator

@hujw77 hujw77 commented Mar 23, 2022 •
edited
Loading

Simply fee market logic

FeeMarket gas used

yarn test test/test_normal_send_message_single.js

·----------------------------------------------------|---------------------------|----------------|-----------------------------·
|                Solc version: 0.8.11                ·  Optimizer enabled: true  ·  Runs: 999999  ·  Block limit: 12450000 gas  │
·····················································|···························|················|······························
|  Methods                                                                                                                      │
·················|···································|·············|·············|················|···············|··············
|  Contract      ·  Method                           ·  Min        ·  Max        ·  Avg           ·  # calls      ·  eur (avg)  │
·················|···································|·············|·············|················|···············|··············
|  InboundLane   ·  receive_messages_proof           ·          -  ·          -  ·        121201  ·            2  ·          -  │
·················|···································|·············|·············|················|···············|··············
|  OutboundLane  ·  receive_messages_delivery_proof  ·          -  ·          -  ·        110036  ·            2  ·          -  │
·················|···································|·············|·············|················|···············|··············
|  OutboundLane  ·  send_message                     ·          -  ·          -  ·        412714  ·            2  ·          -  │
·················|···································|·············|·············|················|···············|··············

SimpleFeeMarket gas used

yarn test test/test_normal_send_message_single_with_simple_fee_market.js

·-------------------------------------------------------|---------------------------|----------------|-----------------------------·
|                 Solc version: 0.8.11                  ·  Optimizer enabled: true  ·  Runs: 999999  ·  Block limit: 12450000 gas  │
························································|···························|················|······························
|  Methods                                                                                                                         │
····················|···································|·············|·············|················|···············|··············
|  Contract         ·  Method                           ·  Min        ·  Max        ·  Avg           ·  # calls      ·  eur (avg)  │
····················|···································|·············|·············|················|···············|··············
|  InboundLane      ·  receive_messages_proof           ·          -  ·          -  ·        121201  ·            2  ·          -  │
····················|···································|·············|·············|················|···············|··············
|  OutboundLane     ·  receive_messages_delivery_proof  ·          -  ·          -  ·         85393  ·            2  ·          -  │
····················|···································|·············|·············|················|···············|··············
|  OutboundLane     ·  send_message                     ·          -  ·          -  ·        228471  ·            2  ·          -  │
····················|···································|·············|·············|················|···············|··············

Gas comparing

SimpleFeeMarket reduce ~ 44% gas in send_message
SimpleFeeMarket reduce ~ 22% gas in receive_messages_delivery_proof

@hackfisher
Copy link
Contributor

Any plans for beefy to support BLS, and the plan of Ethereum to support BLS precompile: https://eips.ethereum.org/EIPS/eip-2537

@hujw77
Copy link
Collaborator Author

hujw77 commented Mar 25, 2022

Any plans for beefy to support BLS, and the plan of Ethereum to support BLS precompile: https://eips.ethereum.org/EIPS/eip-2537

https://github.com/ethereum/go-ethereum/blob/a8040bc2c51605a4cca9e48cac83ff14928d50c2/core/vm/contracts.go#L97

Now, BLS precompile only for testing purposes.

@hujw77
Copy link
Collaborator Author

hujw77 commented Mar 25, 2022

Any plans for beefy to support BLS, and the plan of Ethereum to support BLS precompile: https://eips.ethereum.org/EIPS/eip-2537

https://github.com/ethereum/go-ethereum/blob/a8040bc2c51605a4cca9e48cac83ff14928d50c2/core/vm/contracts.go#L97

Now, BLS precompile only for testing purposes.

There is a roadmap and pr to track the plan
https://github.com/ethereum/annotated-spec/blob/master/images/roadmap.jpeg
ethereum/pm#343

@hujw77 hujw77 closed this Apr 14, 2022
@hujw77 hujw77 mentioned this pull request Apr 15, 2022
Merged
@hujw77 hujw77 deleted the gas/simple_fee_market branch July 27, 2022 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hackfisher hackfisher Awaiting requested review from hackfisher

@xiaoch05 xiaoch05 Awaiting requested review from xiaoch05

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fee market simplify and gas optimization
2 participants
@hujw77 @hackfisher