Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load Boot Configuration from File #427

Closed
chenym1992 opened this issue Jul 3, 2019 · 6 comments · Fixed by #453
Closed

Load Boot Configuration from File #427

chenym1992 opened this issue Jul 3, 2019 · 6 comments · Fixed by #453
Assignees

Comments

@chenym1992
Copy link

启动配置希望可以指定配置文件

@aurexav aurexav self-assigned this Nov 27, 2019
@aurexav
Copy link
Member

aurexav commented Nov 29, 2019

Added: #126

@aurexav aurexav closed this as completed Nov 29, 2019
@aurexav
Copy link
Member

aurexav commented Mar 17, 2020

I'm going to disable this feature in development version.

We'll support this in a production version.

Can be easily inject into cli after restruct the darwinia.

@aurexav aurexav reopened this Mar 17, 2020
@aurexav aurexav changed the title 启动配置希望可以指定配置文件 Load Boot Configuration from File Mar 17, 2020
@yanganto
Copy link
Contributor

This issue is related to the off-chain worker.
#335
https://github.com/darwinia-network/darwinia/pull/335/files#diff-22dd0ecfa9822d47f43e68594e5f64e0R108

The off-chain worker can load different config file with different key

@clearloop
Copy link
Contributor

Suggest using my awesome etc crate to manage configs!

@aurexav aurexav transferred this issue from darwinia-network/darwinia Mar 27, 2020
@aurexav aurexav transferred this issue from darwinia-network/darwinia-common Apr 13, 2020
@aurexav
Copy link
Member

aurexav commented May 7, 2020

This feature will be delayed.

Due to paritytech/substrate#5936 that I can't mutate the config.

aurexav added a commit that referenced this issue May 7, 2020
hackfisher pushed a commit that referenced this issue May 7, 2020
* update: types

* update: version

* update: deps

* update: switch to production env

* todo: #427

* update: version

* update: deps
@aurexav
Copy link
Member

aurexav commented May 8, 2020

paritytech/substrate#5942

This will be fixed in the next substrate upgrade.

@aurexav aurexav linked a pull request Jun 3, 2020 that will close this issue
@aurexav aurexav closed this as completed Jun 3, 2020
@aurexav aurexav linked a pull request Jun 3, 2020 that will close this issue
aurexav added a commit that referenced this issue Jan 4, 2021
aurexav added a commit that referenced this issue Jan 4, 2021
hackfisher pushed a commit that referenced this issue Jan 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants