UnixFD: Handle DBus signals with Unix file descriptors #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move all functions and classes related to the UnixFD support to dasbus.unix.
The `GLibClientUnix` class should be able to handle the result of a client call that might contain Unix file descriptors. The `ClientObjectHandler` class shouldn't support anything related to that.
* Remove the `variant_replace_fdlist_indices_with_handles` function. * Remove the `variant_replace_handles_with_fdlist_indices` function. * Use the `acquire_fds` and `restore_fds` functions instead.
Clean up unit tests for the `UnixFDSwap` class and the related code.
Clean up the implementation of the existing tests and write new ones.
Set and get a property with Unix file descriptors.
GLib doesn't seem to support Unix file descriptors in signals. Swap Unix file descriptors with indexes into a list of Unix file descriptors, but emit just the indexes. Log a warning to inform users about the limited support.
poncovka
force-pushed
the
master-unix_signals
branch
from
acb3078
to
7736e51
Compare
M4rtinK
approved these changes
Oct 10, 2022
|
|
||
|
|
||
| def variant_replace_fdlist_indices_with_handles(v, fdlist): | ||
| """Given a varaint and an fdlist, find any 'h' handle instances |
There was a problem hiding this comment.
Looks like a typo or is some DBus type called like that ?
There was a problem hiding this comment.
It is a typo, but the string was eventually removed in following commits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GLib doesn't seem to support Unix file descriptors in signals. Swap Unix
file descriptors with indexes into a list of Unix file descriptors, but emit
just the indexes. Log a warning to inform users about the limited support.
Depends on: #101