Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Raise TimeoutError if a DBus call times out #92

Merged
merged 1 commit into from
Jun 14, 2022
Merged

Raise TimeoutError if a DBus call times out #92

merged 1 commit into from
Jun 14, 2022

Conversation

poncovka
Copy link
Contributor

@poncovka poncovka commented Jun 9, 2022

  • Raise the TimeoutError exception instead of the original GLib.Error.
  • Improve the documentation of the timeout and add an example.

@poncovka
Raise TimeoutError if a DBus call times out
a76cac7 
* Raise the TimeoutError exception instead of the original GLib.Error.
* Improve the documentation of the timeout and add an example.
@poncovka poncovka added the enhancement New feature or request label Jun 9, 2022
VladimirSlavik
VladimirSlavik approved these changes Jun 13, 2022
View reviewed changes
Copy link

@VladimirSlavik VladimirSlavik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as far as I can tell, thank you!

@poncovka poncovka merged commit ff886cf into dasbus-project:master Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VladimirSlavik VladimirSlavik VladimirSlavik approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poncovka @VladimirSlavik