Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use pylint from pip on Fedora Rawhide #96

Merged
merged 1 commit into from
Aug 15, 2022

Conversation

poncovka
Copy link
Contributor

Temporarily disable the installation of pylint from pip on Fedora Rawhide.
Use the patched system package that supports Python 3.11.

Temporarily disable the installation of pylint from pip on Fedora Rawhide.
Use the patched system package that supports Python 3.11.
@poncovka poncovka added the ci and tests Improvements in CI and tests label Aug 15, 2022
Copy link

@rvykydal rvykydal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@poncovka poncovka merged commit 9bc7d84 into dasbus-project:master Aug 15, 2022
Copy link

@M4rtinK M4rtinK left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me as well. :)

@VladimirSlavik
Copy link

Last time we talked about this, it was suggested we'd be best off freezing the pylint machinery on non-master branches. Of course that leaves some room for interpretation, such as when is the right time to freeze the version etc. Perhaps this is an alternative to that - use what's packaged on that Fedora?

@poncovka
Copy link
Contributor Author

Last time we talked about this, it was suggested we'd be best off freezing the pylint machinery on non-master branches. Of course that leaves some room for interpretation, such as when is the right time to freeze the version etc. Perhaps this is an alternative to that - use what's packaged on that Fedora?

I don't see how freezing the pylint version could fix the tests for Fedora Rawhide. None of the versions available on pip supports Python 3.11 at this moment.

@VladimirSlavik
Copy link

The key part was this:

use what's packaged on that Fedora

Which is what you already do now. You could just do it that way always, that is, never revert this change...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci and tests Improvements in CI and tests
Development

Successfully merging this pull request may close these issues.

4 participants