UnixFD: Move the unit tests to a new file #97
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Remove extra lines. * Improve the indentation.
Split the testing DBus interface and create a new one for UnixFD.
poncovka
added
ci and tests
jkonecny12
approved these changes
Aug 17, 2022
tests/test_dbus.py
Outdated
| proxy_args={"client": GLibClientUnix}) | ||
| super().setUp() | ||
| self.server_args = {"server": GLibServerUnix} | ||
| self.client_args = {"client": GLibClientUnix} |
There was a problem hiding this comment.
Is it on purpose that here the variable is named client_args (renamed from proxy_args) but parent have it still as proxy_args? If yes, could you please explain this split in the commit message?
There was a problem hiding this comment.
It was a bug. Good catch!
The attributes can be set later.
The bus should be set up and teared down in the `setUp` and `tearDown` methods of the `TestCase` class. Otherwise, the resources might not be cleaned up.
Create a new file for the UnixFD tests.
poncovka
force-pushed
the
master-unix_clean_up_tests
branch
from
966f001
to
e860423
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up tests for the Unix file descriptors and move them to a new file.