forked from Chia-Network/bls-signatures
-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bench: make benchmarks a bit more useful #106
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
``` Serialize PrivateKey Total: 5000000 runs in 138 ms Avg: 2.76e-05 ms Serialize G1Element Total: 5000000 runs in 1020 ms Avg: 0.000204 ms Serialize G2Element Total: 5000000 runs in 1517 ms Avg: 0.0003034 ms SerializeToArray PrivateKey Total: 5000000 runs in 60 ms Avg: 1.2e-05 ms SerializeToArray G1Element Total: 5000000 runs in 918 ms Avg: 0.0001836 ms SerializeToArray G2Element Total: 5000000 runs in 1426 ms Avg: 0.0002852 ms ```
UdjinM6
changed the title
bench: add serialization benchmarks, use BasicSchemeMPL in existing benchmarks, drop irrelevant ones
bench: make benchmarks a bit more useful
Dec 6, 2024
PastaPastaPasta
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK 90fd986
kwvg
approved these changes
Dec 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK 90fd986
Merged
5 tasks
PastaPastaPasta
added a commit
to dashpay/dash
that referenced
this pull request
Dec 17, 2024
…bb5c5b0 as efd5c56 3bbe16c build: stop tracking cmake dependency relic_conf.h.in (Kittywhiskers Van Gogh) efd5c56 Squashed 'src/dashbls/' changes from 7e747e8a07..0bb5c5b032 (Kittywhiskers Van Gogh) 257fd5e revert: stop tracking cmake dependency relic_conf.h.in (Kittywhiskers Van Gogh) Pull request description: ## Additional Information * Dependency for #6493 * Expected subtree hash `7bec74f04710e6031590283cf405e3f141bc63310cafe5e70aae9b8d4c98cbef` (see [instructions](#6323 (review)) to calculate) * Includes [bls-signatures#75](dashpay/bls-signatures#75) and [bls-signatures#106](dashpay/bls-signatures#106) ## Breaking Changes None expected. ## Checklist: - [x] I have performed a self-review of my own code **(note: N/A)** - [x] I have commented my code, particularly in hard-to-understand areas **(note: N/A)** - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)** - [x] I have made corresponding changes to the documentation **(note: N/A)** - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_ ACKs for top commit: PastaPastaPasta: utACK 3bbe16c UdjinM6: subtree looks good, utACK 3bbe16c Tree-SHA512: 3f6853f90dfe5e3040189742858b6728e4ab505513202216f1e2f7213569798d2f2e346d73ece7505f87dc2439fde4c3a51472461163fc7c21734a734cbc0bdb
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add serialization benchmarks, use BasicSchemeMPL in existing benchmarks, drop irrelevant ones
Results (m1 pro)