Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bench: make benchmarks a bit more useful #106

Merged
merged 3 commits into from
Dec 6, 2024

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Dec 6, 2024

Add serialization benchmarks, use BasicSchemeMPL in existing benchmarks, drop irrelevant ones

Results (m1 pro)
Signing
Total: 5000 runs in 3835 ms
Avg: 0.767 ms

Verification
Total: 1000 runs in 2527 ms
Avg: 2.527 ms

Batch verification preparation
Total: 10000 runs in 8786 ms
Avg: 0.8786 ms

Public key validation
Total: 10000 runs in 1896 ms
Avg: 0.1896 ms

Signature validation
Total: 10000 runs in 2048 ms
Avg: 0.2048 ms

Aggregation
Total: 10000 runs in 20 ms
Avg: 0.002 ms

Batch verification
Total: 10000 runs in 11056 ms
Avg: 1.1056 ms

Serialize PrivateKey
Total: 5000000 runs in 134 ms
Avg: 2.68e-05 ms

Serialize G1Element
Total: 5000000 runs in 1036 ms
Avg: 0.0002072 ms

Serialize G2Element
Total: 5000000 runs in 1541 ms
Avg: 0.0003082 ms

SerializeToArray PrivateKey
Total: 5000000 runs in 61 ms
Avg: 1.22e-05 ms

SerializeToArray G1Element
Total: 5000000 runs in 936 ms
Avg: 0.0001872 ms

SerializeToArray G2Element
Total: 5000000 runs in 1444 ms
Avg: 0.0002888 ms

```
Serialize PrivateKey
Total: 5000000 runs in 138 ms
Avg: 2.76e-05 ms

Serialize G1Element
Total: 5000000 runs in 1020 ms
Avg: 0.000204 ms

Serialize G2Element
Total: 5000000 runs in 1517 ms
Avg: 0.0003034 ms

SerializeToArray PrivateKey
Total: 5000000 runs in 60 ms
Avg: 1.2e-05 ms

SerializeToArray G1Element
Total: 5000000 runs in 918 ms
Avg: 0.0001836 ms

SerializeToArray G2Element
Total: 5000000 runs in 1426 ms
Avg: 0.0002852 ms
```
@UdjinM6 UdjinM6 changed the title bench: add serialization benchmarks, use BasicSchemeMPL in existing benchmarks, drop irrelevant ones bench: make benchmarks a bit more useful Dec 6, 2024
@kwvg kwvg mentioned this pull request Dec 6, 2024
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 90fd986

Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 90fd986

@PastaPastaPasta PastaPastaPasta merged commit 3170e82 into dashpay:develop Dec 6, 2024
25 checks passed
PastaPastaPasta added a commit to dashpay/dash that referenced this pull request Dec 17, 2024
…bb5c5b0 as efd5c56

3bbe16c build: stop tracking cmake dependency relic_conf.h.in (Kittywhiskers Van Gogh)
efd5c56 Squashed 'src/dashbls/' changes from 7e747e8a07..0bb5c5b032 (Kittywhiskers Van Gogh)
257fd5e revert: stop tracking cmake dependency relic_conf.h.in (Kittywhiskers Van Gogh)

Pull request description:

  ## Additional Information

  * Dependency for #6493
  * Expected subtree hash `7bec74f04710e6031590283cf405e3f141bc63310cafe5e70aae9b8d4c98cbef` (see [instructions](#6323 (review)) to calculate)
  * Includes [bls-signatures#75](dashpay/bls-signatures#75) and [bls-signatures#106](dashpay/bls-signatures#106)

  ## Breaking Changes

  None expected.

  ## Checklist:

  - [x] I have performed a self-review of my own code **(note: N/A)**
  - [x]  I have commented my code, particularly in hard-to-understand areas **(note: N/A)**
  - [x] I have added or updated relevant unit/integration/functional/e2e tests **(note: N/A)**
  - [x] I have made corresponding changes to the documentation **(note: N/A)**
  - [x] I have assigned this pull request to a milestone _(for repository code-owners and collaborators only)_

ACKs for top commit:
  PastaPastaPasta:
    utACK 3bbe16c
  UdjinM6:
    subtree looks good, utACK 3bbe16c

Tree-SHA512: 3f6853f90dfe5e3040189742858b6728e4ab505513202216f1e2f7213569798d2f2e346d73ece7505f87dc2439fde4c3a51472461163fc7c21734a734cbc0bdb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants