Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: aarch64 is not supported, should set ARCH to RELIC_NONE #90

Merged
merged 1 commit into from
Oct 4, 2024
Merged

fix: aarch64 is not supported, should set ARCH to RELIC_NONE #90

merged 1 commit into from
Oct 4, 2024

Conversation

UdjinM6
Copy link

@UdjinM6 UdjinM6 commented Sep 20, 2024

@UdjinM6 UdjinM6 requested a review from kwvg September 20, 2024 22:16
kwvg
kwvg approved these changes Sep 24, 2024
View reviewed changes
Copy link
Collaborator

@kwvg kwvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, utACK 4fd4e8c

@kwvg kwvg mentioned this pull request Sep 25, 2024
Closed
@UdjinM6 UdjinM6 requested a review from knst September 27, 2024 15:00
@ogabrielides ogabrielides mentioned this pull request Sep 28, 2024
Merged
@PastaPastaPasta
Copy link
Member

What's the deal about these test failures?

@kwvg
Copy link
Collaborator

kwvg commented Oct 4, 2024

@PastaPastaPasta, most CI failures are resolved with bls-signatures#91

@PastaPastaPasta
Copy link
Member

let's merge that first then

@PastaPastaPasta PastaPastaPasta mentioned this pull request Oct 4, 2024
Closed
5 tasks
@PastaPastaPasta
Copy link
Member

rebased via GitHub interface to see CI happy. @UdjinM6 please rebase again to add sigs

@PastaPastaPasta PastaPastaPasta merged commit 062ee67 into dashpay:develop Oct 4, 2024
22 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kwvg kwvg kwvg approved these changes

@PastaPastaPasta PastaPastaPasta PastaPastaPasta approved these changes

@knst knst Awaiting requested review from knst

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@UdjinM6 @PastaPastaPasta @kwvg