Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix buildx var substitution in compose file #248

Merged
merged 1 commit into from
Aug 11, 2021
Merged

ci: fix buildx var substitution in compose file #248

merged 1 commit into from
Aug 11, 2021

Conversation

strophy
Copy link
Collaborator

@strophy strophy commented Aug 9, 2021

Issue being fixed or feature implemented

Buildx v0.6.0 contains a bug that prevents variable substitution in docker compose files

What was done?

Force installation of v0.6.1, which contains a fix

How Has This Been Tested?

Tested working on update-grpc branch

Breaking Changes

None

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@strophy strophy added this to the v0.20.x milestone Aug 9, 2021
@strophy strophy requested a review from shumkov August 9, 2021 10:28
@strophy strophy mentioned this pull request Aug 9, 2021
Closed
5 tasks
shumkov
shumkov requested changes Aug 9, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You committed something else ))

@strophy strophy requested a review from shumkov August 11, 2021 12:08
shumkov
shumkov approved these changes Aug 11, 2021
View reviewed changes
Copy link
Member

@shumkov shumkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@strophy strophy merged commit ad7550b into master Aug 11, 2021
@strophy strophy deleted the fix-buildx-2 branch August 11, 2021 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shumkov shumkov shumkov approved these changes

@antouhou antouhou antouhou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.20.x
Development

Successfully merging this pull request may close these issues.
3 participants
@strophy @shumkov @antouhou