Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement caching in CRecoveredSigsDb #2706

Merged
merged 1 commit into from
Feb 16, 2019

Conversation

codablock
Copy link

To avoid repeated calls into LevelDB

To avoid repeated calls into LevelDB
@UdjinM6 UdjinM6 added this to the 14.0 milestone Feb 15, 2019
src/llmq/quorums_signing.h Show resolved Hide resolved
src/llmq/quorums_signing.cpp Show resolved Hide resolved
src/llmq/quorums_signing.cpp Show resolved Hide resolved
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK

@codablock codablock merged commit feb4e0a into dashpay:develop Feb 16, 2019
@codablock codablock deleted the pr_llmq_optimizations3 branch February 16, 2019 14:51
Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

post-utACK

Fuzzbawls added a commit to PIVX-Project/PIVX that referenced this pull request Aug 9, 2024
22efef0 No matter how fast we process sig shares, always force 100ms between sending (Alexander Block)
1bd0c2f Don't sleep in WorkThreadMain when CPU intensive work was done (Alexander Block)
40a247d Implement caching in CRecoveredSigsDb (Alexander Block)
6c63a77 Use CBLSLazySignature in CBatchedSigShares (Alexander Block)
bff6e6e CLLMQUtils::IsQuorumActive() shouldn't require cs_main to be held (UdjinM6)
fdba615 Introduce startBlockHeight to make things more explicit (Alexander Block)
7bca9a2 Correctly use SIGN_HEIGHT_OFFSET when checking for out of bound height (Alexander Block)
04b6a67 Reserve 4k of buffer for CSerializedNetMsg buffer (Alexander Block)
be1c4a7 Fix cleanup of old recovered sigs (Alexander Block)

Pull request description:

  Backport dash PRs (in the following order):
  dashpay#2640
  dashpay#2672
  dashpay#2674
  dashpay#2702
  dashpay#2705
  dashpay#2706
  dashpay#2707

  NB: Some or them are partial backports since most of our llmq files are already updated to a more recent upstream version. So I basically ended up picking the commits that touch only the files `quorums_signing_shares.*` and `quorums_signing.*`

  I suggest to review by checking each individual commit against the corresponding upstream one

ACKs for top commit: 22efef0
  Liquid369:
    tACK 22efef0
  Duddino:
    ACK 22efef0

Tree-SHA512: 94e5dcdef044524ad4fa4d1fadbe670d839a08ccadc39071ba9300cfc44ce3d19ba24dfef1a6c6745271139d43f43ea47ed5a29e06f0d94e13ff09957f8e0c10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants