Fix relaying of governance objects when collaterals are not fully confirmed #3018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A bug in CGovernanceObject::IsCollateralValid caused governance objects to be rejected when the collateral was IS locked and not fully confirmed on-chain. The intention was to actually accept such objects and relay them. This changes IsCollateralValid to accept such collaterals but also gives the caller the required info to postpone relaying of such objects for older peers.
And postpone relaying to older peers until the object's collateral is fully confirmed.
|
As discussed in Slack, we should better completely remove support for InstantSend for gobject collaterals. This is not used often enough to justify the complexity. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages. We might need to backport this to 0.14.0.x, but I'm not 100% sure about it. The current behavior on mainnet should be that governance objects are simply not relayed until the collateral is fully confirmed. There is however a small chance of nodes getting banned by other nodes when they try to relay an object before the first on-chain confirmation, but IMHO the chance is pretty small and it's also not usable for an attack (as it would be quite expensive due to burning of 5 Dash).