-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: blockchain updates for v20.1: chainparams, seeds #5914
Conversation
solved, see commit messages |
9c6594f
to
4af12d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks mostly ok, one issue, see below. Also, what about testnet?
Hmm, mr_rr is not activated yet on testnet so probably no reorganize would happen. I'll update then. |
4af12d9
to
1d685f7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:D
1d685f7
to
8daf938
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK (verified blockhashes etc. in chainparams)
8daf938
to
222e413
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
utACK; rebased to change commit names a bit
Don't forget to specify onion_seeds.txt: ``` cd contrib/seeds dash-cli protx list valid 1 > protx.txt ./makeseeds.py protx.txt onion_seeds.txt > nodes_main.txt ./generate-seeds.py . > ../../src/chainparamsseeds.h ```
``` $ ./makeseeds.py protx.txt > nodes_main.txt Traceback (most recent call last): File "DASH/contrib/seeds/./makeseeds.py", line 183, in <module> main() File "DASH/contrib/seeds/./makeseeds.py", line 167, in main for onion in onions: ^^^^^^ UnboundLocalError: cannot access local variable 'onions' where it is not associated with a value ```
222e413
to
97a331c
Compare
Issue being fixed or feature implemented
Part of release process to update seeds and chainparams: https://github.com/dashpay/dash/blob/develop/doc/release-process.md
Breaking Changes
N/A
Checklist: