Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: blockchain updates for v20.1: chainparams, seeds #5914

Merged
merged 5 commits into from
Mar 4, 2024

Conversation

knst
Copy link
Collaborator

@knst knst commented Feb 29, 2024

Issue being fixed or feature implemented

Part of release process to update seeds and chainparams: https://github.com/dashpay/dash/blob/develop/doc/release-process.md

Breaking Changes

N/A

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation
  • I have assigned this pull request to a milestone

@knst knst added this to the 20.1 milestone Feb 29, 2024
@knst
Copy link
Collaborator Author

knst commented Feb 29, 2024

there's something wrong with tor on my machine, it says all onions' hosts are unavailable.

solved, see commit messages

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks mostly ok, one issue, see below. Also, what about testnet?

src/chainparams.cpp Outdated Show resolved Hide resolved
@knst
Copy link
Collaborator Author

knst commented Feb 29, 2024

. Also, what about testnet?

Hmm, mr_rr is not activated yet on testnet so probably no reorganize would happen. I'll update then.

Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:D

src/chainparams.cpp Outdated Show resolved Hide resolved
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK (verified blockhashes etc. in chainparams)

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK; rebased to change commit names a bit

knst added 5 commits March 3, 2024 23:34
Don't forget to specify onion_seeds.txt:
```
cd contrib/seeds
dash-cli protx list valid 1 > protx.txt
./makeseeds.py protx.txt onion_seeds.txt > nodes_main.txt
./generate-seeds.py . > ../../src/chainparamsseeds.h
```
```
$ ./makeseeds.py protx.txt > nodes_main.txt
Traceback (most recent call last):
  File "DASH/contrib/seeds/./makeseeds.py", line 183, in <module>
    main()
  File "DASH/contrib/seeds/./makeseeds.py", line 167, in main
    for onion in onions:
                 ^^^^^^
UnboundLocalError: cannot access local variable 'onions' where it is not associated with a value
```
@PastaPastaPasta PastaPastaPasta merged commit 5e95f8d into dashpay:develop Mar 4, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants