backport: merge bitcoin#26519, #25880, #26982, #26584, #27577, #28419, #28196, #28433, #28489, #28525 (BIP324 backports)

[kwvg]

Additional Information

• When backporting bitcoin#25880, changes needed to be made to p2p_ibd_stalling.py to help it pass.

  • DIP3 activation had to be delayed to a block beyond the range of the test. This is to prevent block rejection arising from a missing DIP3-compliant coinbase (done with -dip3params=2000:2000)
  • Mock time was disabled to ensure nodes in the test do not resort to direct fetching (with mock time enabled, nodes would be considered close apart in time, which would prevent the primary node from fetching in parallel, which is behavior this test relies on) (done with self.disable_mocktime = True)
  • The nodes connected do not report compressed headers support (the test relies on sending headers messages and reworking it to use compressed headers has little benefit) (done with services = NODE_NETWORK | NODE_BLOOM)

• When backporting bitcoin#28196, in the v2transport_test unit test, references to 4000000 were substituted with MAX_PROTOCOL_MESSAGE_LENGTH as Dash messages have a protocol limit of 3MiB (source) while Bitcoin messages have a protocol limit of 4MB (source).

  • Additionally note that short message IDs as defined in the BIP324 spec (source) have not been changed to include Dash-specific messages, meaning, Dash-specific messages will always take 13 bytes.
  • As FEEFILTER is not supported by Dash, it has been replaced with a blank string in the short IDs table. It was not removed as doing so would disturb the table's arrangement as specified in spec and require readjustment of tests to account for the change in layout.

Breaking Changes

None expected.

Checklist

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas (note: N/A)
• I have added or updated relevant unit/integration/functional/e2e tests
• I have made corresponding changes to the documentation (note: N/A)
• I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

[PastaPastaPasta]

utACK 397f34a

[UdjinM6]

Additionally note that short message IDs as defined in the BIP324 spec (source) have not been changed to include Dash-specific messages, meaning, Dash-specific messages will always take 13 bytes

message_type ... a one byte ID in range 1..255

only 28 IDs are used in Bitcoin so why don't we use IDs 128+ for Dash-specific messages? Doubt they'll get to these numbers anytime soon. @PastaPastaPasta ?

also pls see da5b56c

[PastaPastaPasta]

only 28 IDs are used in Bitcoin so why don't we use IDs 128+ for Dash-specific messages? Doubt they'll get to these numbers anytime soon. @PastaPastaPasta ?

@UdjinM6
This is actually the goal in the not so distant future, probably before we actually merge in stuff where it's actually usable. If not, we'll do that via a new protocol version. Excluding that for now was just to expedite the process, as the code doesn't have a trivial way to just start at 128 for example if I remember correctly

[UdjinM6]

utACK 63b13aa

[knst]

utACK 63b13aa

[knst]

"FEEFILTER_NOT_SUPPORTED" is better than empty string here IMO, to avoid mixing with other possible errors

Suggested change

	"", /* FEEFILTER is not implemented in Dash */
	"FEEFILTER_NOT_SUPPORTED",