Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: call self.generate() in p2p_net_deadlock.py (follow-up dash#6276) #6315

Merged
merged 1 commit into from
Oct 5, 2024

Conversation

kwvg
Copy link
Collaborator

@kwvg kwvg commented Oct 5, 2024

Additional Information

develop is currently borked (build) because dash#6288 changed the expected syntax for generate* calls and dash#6276 introduced a new test (p2p_net_deadlock.py) that was based on a version of develop that used the older syntax.

No conflicts were reported because it was a new file introduced in the latter PR that the former PR did not have knowledge of.

Breaking changes

None expected.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas (note: N/A)
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation (note: N/A)
  • I have assigned this pull request to a milestone (for repository code-owners and collaborators only)

@kwvg kwvg added this to the 21.2 milestone Oct 5, 2024
@kwvg kwvg marked this pull request as ready for review October 5, 2024 10:31
Copy link

@UdjinM6 UdjinM6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9b0c506

Copy link
Member

@PastaPastaPasta PastaPastaPasta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

utACK 9b0c506

@PastaPastaPasta PastaPastaPasta merged commit bda01b1 into dashpay:develop Oct 5, 2024
35 checks passed
@UdjinM6 UdjinM6 modified the milestones: 21.2, 22 Oct 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants