Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Hot Masternode #773

Merged
merged 1 commit into from
May 10, 2016
Merged

Fix Hot Masternode #773

merged 1 commit into from
May 10, 2016

Conversation

thelazier
Copy link

@thelazier thelazier commented May 10, 2016

Revert to use same value as master branch.

@UdjinM6
Copy link

UdjinM6 commented May 10, 2016

Hmm.. I'm not sure what this fixes and why https://github.com/dashpay/dash/blob/v0.12.0.x/src/activemasternode.cpp#L81

@schinzelh
Copy link

schinzelh commented May 10, 2016

Thats strange, in master (0.12.0.56) this is set to true:

https://github.com/dashpay/dash/blob/master/src/activemasternode.cpp#L81

In the end it prevents masternodes to be started locally

@UdjinM6
Copy link

UdjinM6 commented May 10, 2016

yes, in master it's true but #706

@UdjinM6
Copy link

UdjinM6 commented May 10, 2016

Ahh... I see now. So for local MN start it's an exceptional case which is the opposite to the natural way it was designed... hmm.. ok, let's make that change but we need to remove pnode->Release(); at line 93 too then.

@thelazier
Copy link
Author

if pnode-release() need to remove, should we revert the pnode line as well? so it will be back to master branch version.

@UdjinM6
Copy link

UdjinM6 commented May 10, 2016

Yes, I think that makes sense.

Revert to master branch
@UdjinM6
Copy link

UdjinM6 commented May 10, 2016

ACK 56adee2

@UdjinM6
Copy link

UdjinM6 commented May 10, 2016

On another note - I think we should make hot masternodes redundant one day and clean up the code. But for now - it's ok.

@schinzelh
Copy link

Maybe we should deprecate hot nodes anyway, as it is nuts to have $7000 online 24/7

@schinzelh schinzelh merged commit e5bcd05 into dashpay:v0.12.1.x May 10, 2016
@thelazier thelazier deleted the patch-1 branch May 10, 2016 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants