Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change extended key version bytes to BIP32 #926

Merged
merged 4 commits into from
Aug 1, 2016
Merged

Change extended key version bytes to BIP32 #926

merged 4 commits into from
Aug 1, 2016

Conversation

andyfreer
Copy link

@andyfreer andyfreer commented Aug 1, 2016

-Most compatible solution

@schinzelh
Copy link

I'll leave it here for reference: https://www.reddit.com/r/litecoin/comments/48wd2e/why_arent_the_litecoin_bip32_serialization_values/

The proper values are the ones in the reference client. The same convention of using xpub/xprv was also adopted by Electrum-LTC. You may run into software using Ltub/Ltpv, but that format should be considered non-standard.
By the way, let me point out that this is only a presentational matter. Extended keys can be converted from the Ltub/Ltpv convention to the standard one relatively easily.

We'll follow the same path and use xpub/xprv starting with 0.12.1

@andyfreer andyfreer changed the title Revert changing BIP32 version bytes to maintain existing Dash versions Change to extended key version bytes to BIP32 Aug 1, 2016
@andyfreer andyfreer changed the title Change to extended key version bytes to BIP32 Change extended key version bytes to BIP32 Aug 1, 2016
@schinzelh
Copy link

utACK c874a0f

@UdjinM6
Copy link

UdjinM6 commented Aug 1, 2016

Looks good for me, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants