-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(dashmate): add images migrations for v25 #1377
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pshenmic
commented
Sep 7, 2023
pshenmic
force-pushed
the
feat/dashmate-v25-images
branch
from
September 17, 2023 08:31
544e06c
to
ba5265a
Compare
…5-images # Conflicts: # packages/dashmate/configs/defaults/getBaseConfigFactory.js # packages/dashmate/configs/defaults/getTestnetConfigFactory.js # packages/dashmate/configs/getConfigFileMigrationsFactory.js
shumkov
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
shumkov
approved these changes
Sep 20, 2023
strophy
approved these changes
Sep 20, 2023
shumkov
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
Migrations missing for v25 dapi, drive and tenderdash images, resulting in incorrect (v24) images after dashmate upgrade on end users machines.
What was done?
Added new migration for setting proper v24 docker images for dapi, tenderdash and drive
How Has This Been Tested?
Locally
Breaking Changes
No
Checklist:
For repository code-owners and collaborators only