-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: disable runs on draft prs #1380
Conversation
This PR only disables self-hosted CI, Github-hosted actions will still run. Should we consider reducing the frequency of the scheduled run as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe we want runs for drafts
@QuantumExplorer please review, we changed the task slightly to set a label instead of draft status, so that we can still run CI on drafts, and use the draft status to indicate whether something is ready to be merged yet or not |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI won't work even if pull request is not a draft but doesn't have ci label?
Right, the |
So we adding an extra step to add label? What if you didn't add this label? PR looks green even without running workflows? TBH, this improvement looks to me as a complication of our development process and adds risks to merge PRs without testing. @lklimek and @markin-io your thoughts? |
@QuantumExplorer you requested this, can you guys please align on what you actually want and comment here? |
ci
label is added to PR
My request that we no longer run CI for draft PRs. I push many many times a day when I'm in active development. @shumkov why would you want CI on drafts? |
To see all tests are passing before I request a review |
@strophy Talked to @QuantumExplorer. Please just do not run CI for drafts. No label logic. Trigger CI when we switch from draft to normal PR. So in my case I will just switch to normal PR wait for CI and then switch back to draft. |
ci
label is added to PRThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Issue being fixed or feature implemented
To reduce costs, we should only run CI when devs are ready for a check.
What was done?
Check for
ci
label on PRs before triggering self-hosted CI jobsHow Has This Been Tested?
In this PR by adding/removing the tag and doing test pushes
Breaking Changes
None
Checklist:
For repository code-owners and collaborators only