Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(dpp): remove unused cbor import #1384

Merged
merged 1 commit into from
Sep 19, 2023
Merged

style(dpp): remove unused cbor import #1384

merged 1 commit into from
Sep 19, 2023

Conversation

pshenmic
Copy link
Collaborator

@pshenmic pshenmic commented Sep 8, 2023

Issue being fixed or feature implemented

CborCanonicalMap is not used anymore in the contract bounds, but still being imported in the file, making applications fail to build rs-dpp when used externally.

warning: `platform-serialization-derive` (lib) generated 2 warnings
   Compiling dpp v0.1.0 (/Users/pshenmic/WebstormProjects/platform/packages/rs-dpp)
error[E0432]: unresolved import `crate::util::cbor_value`
 --> /Users/pshenmic/WebstormProjects/platform/packages/rs-dpp/src/identity/identity_public_key/contract_bounds/mod.rs:5:18
  |
5 | use crate::util::cbor_value::{CborCanonicalMap, CborMapExtension};
  |                  ^^^^^^^^^^ could not find `cbor_value` in `util`

What was done?

Removed the crashing import line

How Has This Been Tested?

Removing this line makes rs-dpp to succesfully compile when used in external Rust project

Breaking Changes

No

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated relevant unit/integration/functional/e2e tests
  • I have made corresponding changes to the documentation

For repository code-owners and collaborators only

  • I have assigned this pull request to a milestone

@pshenmic pshenmic added this to the v0.25.0 milestone Sep 8, 2023
@pshenmic pshenmic self-assigned this Sep 8, 2023
@pshenmic pshenmic changed the title fix(rs-dpp): remove unused cbor import fix(dpp): remove unused cbor import Sep 8, 2023
@shumkov shumkov changed the title fix(dpp): remove unused cbor import style(dpp): remove unused cbor import Sep 19, 2023
@shumkov shumkov merged commit c762e36 into v0.25-dev Sep 19, 2023
26 of 27 checks passed
@shumkov shumkov deleted the fix/rs-dpp-import branch September 19, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants